Skip to content

[Magiclysm] allow adept weapons as recipe tools#60633

Merged
dseguin merged 3 commits intoCleverRaven:masterfrom
MrDraMaster:magiclysm/allow-adept-weapons-as-recipe-tools
Sep 1, 2022
Merged

[Magiclysm] allow adept weapons as recipe tools#60633
dseguin merged 3 commits intoCleverRaven:masterfrom
MrDraMaster:magiclysm/allow-adept-weapons-as-recipe-tools

Conversation

@MrDraMaster
Copy link
Contributor

@MrDraMaster MrDraMaster commented Aug 31, 2022

Summary

Mods "Allow adept weapons as tools in recipes already using normal class weapons"

Purpose of change

Magiclysm recipes that allow a class weapon instead of a class rune as a tool do not allow the class adept weapon.

Describe the solution

Add the technomancer, animist, and magus adept weapon in all recipes with the "normal" version was used as a tool option.

Describe alternatives you've considered

Testing

  • create new world
  • debug => all recipes known
  • check that recipes with t:animist, t:technomancer, and t:magus also mention the adept version of the weapon
  • debug => grant the three adept weapons
  • check recipes again to see that the adept weapons are highlighted green for present

Additional context

@MrDraMaster MrDraMaster requested a review from KorGgenT as a code owner August 31, 2022 18:07
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod labels Aug 31, 2022
@MrDraMaster MrDraMaster changed the title Magiclysm/allow adept weapons as recipe tools [Magiclysm] allow adept weapons as recipe tools Aug 31, 2022
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Thanks for contributing!

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 1, 2022
@dseguin dseguin merged commit d955cf1 into CleverRaven:master Sep 1, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 1, 2022
@MrDraMaster MrDraMaster deleted the magiclysm/allow-adept-weapons-as-recipe-tools branch September 1, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants