Add casts and widen a variable to make MSVC happy#60568
Merged
dseguin merged 1 commit intoCleverRaven:masterfrom Sep 1, 2022
Merged
Add casts and widen a variable to make MSVC happy#60568dseguin merged 1 commit intoCleverRaven:masterfrom
dseguin merged 1 commit intoCleverRaven:masterfrom
Conversation
github-actions
bot
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
MSVC spams build output with template messages because of implicit size_t to int and double to int conversions
Describe the solution
Widens one variable and adds a few casts to squelch warnings
Not too sure why this doesn't appear to be an issue on clang/gcc in CI, may be different templates in stdlib or warning turned off?
Describe alternatives you've considered
Testing
Run a clean rebuild, at the end of it there should be nothing extra in output window except list of files and no warnings / messages in error list window.
Additional context
4 warnings/39 messages before patch - 0/0 after
647 lines of output before patch - 377 lines of output after patch = ~270 lines of template warning copypasta