Skip to content

Documentation: Added the USE_PLAYER_ENERGY flag from existing code#60180

Merged
Fris0uman merged 2 commits intoCleverRaven:masterfrom
RedMisao:patch-2
Sep 1, 2022
Merged

Documentation: Added the USE_PLAYER_ENERGY flag from existing code#60180
Fris0uman merged 2 commits intoCleverRaven:masterfrom
RedMisao:patch-2

Conversation

@RedMisao
Copy link
Contributor

Summary

Infrastructure "Documentation: Added the USE_PLAYER_ENERGY flag from existing code"

Purpose of change

Added the USE_PLAYER_ENERGY flag in the JSON_FLAGS.md doc and a brief description of what it does. The actual code was added some time ago by KorG I believe, but the documentation was missing.
Also minor editions to the doc itself: moved Use actions from Books into Tools, added format to the FILTHY flags, and added the Effects title linking in the index.

Describe the solution

Describe alternatives you've considered

Testing

  1. Created a new PC with a modded item that casts spells using the USE_PLAYER_ENERGY flag.
  2. Checked mana pool: 1000 units.
  3. activated the item, casted a spell that costs 200 units.
  4. Spell was casted, mana pool was reduced by 200 units.

Additional context

These images show that the flag is working as intended for the last August 15 experimental.

1
(Note: this to show the total mana pool, I don't know how to enable displaying the mana pool on the sidebar)

2
3
4

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 15, 2022
@Fris0uman Fris0uman changed the title Update Documentation: Added the USE_PLAYER_ENERGY flag from existing code Aug 16, 2022
Maleclypse
Maleclypse previously approved these changes Aug 28, 2022
@Maleclypse Maleclypse dismissed their stale review August 28, 2022 04:59

I feel like the line count is weird

@Maleclypse
Copy link
Member

Do you need to rebase? I'm trying to understand why your 1 line change is changing 100 lines?

@RedMisao
Copy link
Contributor Author

Do you need to rebase? I'm trying to understand why your 1 line change is changing 100 lines?

I also moved the "Use actions" section that was under "Books" to the "Tools" section.

@Fris0uman Fris0uman merged commit fe8ca70 into CleverRaven:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants