CMake: Clean up if commands and fix compilation with MSYS ncurses#56799
Merged
ZhilkinSerg merged 2 commits intoCleverRaven:masterfrom Apr 16, 2022
Merged
CMake: Clean up if commands and fix compilation with MSYS ncurses#56799ZhilkinSerg merged 2 commits intoCleverRaven:masterfrom
ZhilkinSerg merged 2 commits intoCleverRaven:masterfrom
Conversation
github-actions
bot
added
[C++]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build "CMake: Clean up if commands and fix compilation with MSYS ncurses"
Purpose of change
CMake if command expands unquoted string if it happens to be a variable name, which may cause quirks during compilation.
Also fixes compilation with MSYS ncurses.
Describe the solution
Quote string in if commands where appropriate.
Define some macros to use the correct ncurses lib version.
Fix installation directory error from CMake by setting directory paths to those used for Windows when compiling with MSYS ncurses.
Testing
Successfully compiled using CMake and MinGW-w64 or MSYS2 MSYS.