Allow build and run in repo folder in CMake#52976
Merged
kevingranade merged 1 commit intoCleverRaven:masterfrom Nov 24, 2021
Merged
Allow build and run in repo folder in CMake#52976kevingranade merged 1 commit intoCleverRaven:masterfrom
kevingranade merged 1 commit intoCleverRaven:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build "Allow build and run in repo folder in CMake"
Purpose of change
When compiling a
-O2build,DATA_DIR_PREFIXmacro is defined in CMake build script and there is no way to configure this behaviour. It makes running the game in repo impossible, because C++ code sets internal prefix path to<base_path>/share/cataclysm-ddawhen the macro is defined, and only a few sub directories can be manually override via launch parameters.Describe the solution
Add
USE_PREFIX_DATA_DIRCMake option defaults to true that controls the behaviour of definingDATA_DIR_PREFIXmacro inReleasebuild.Describe alternatives you've considered
Testing
Additional context