Set directories on macOS in CMake build script#50594
Merged
ZhilkinSerg merged 1 commit intoCleverRaven:masterfrom Aug 8, 2021
Merged
Set directories on macOS in CMake build script#50594ZhilkinSerg merged 1 commit intoCleverRaven:masterfrom
ZhilkinSerg merged 1 commit intoCleverRaven:masterfrom
Conversation
BrettDong
added
<Bugfix>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build "Set directories on macOS in CMake build script"
Purpose of change
After #50581 was merged, I get
because directories including
${LOCALE_DIR},${DATA_PREFIX}are not set on macOS. They are only assigned on Linux, FreeBSD or Windows.Describe the solution
Set those directories the same way as on Linux and FreeBSD, so CMake configuration can finish successfully on macOS.
Describe alternatives you've considered
A Cataclysm.app bundle makes more sense for macOS, but I don't have time to implement it in CMake.
Testing
CMake configuration can finish successfully on macOS.
Additional context