cmake: don't use PREFIX variable#50564
Merged
ZhilkinSerg merged 1 commit intoCleverRaven:masterfrom Aug 7, 2021
Merged
Conversation
`PREFIX` is a reserved word in CMake and breaks compiler and library detection when set. Using `CMAKE_INSTALL_PREFIX` instead resolves this.
BrettDong
added
the
Code: Build
actual-nh
added
0.F Backport Candidate
<Bugfix>
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build "Avoid use of reserved word PREFIX in CMake build script"
Purpose of change
The
PREFIXvariable appears to be a reserved word in CMake. When set, it breaks compiler and library detection, so this should not be used to specify the installation directory.Describe the solution
Remove the use of
PREFIXin CMakeLists.txt, and instead useCMAKE_INSTALL_PREFIXfor this purpose.Describe alternatives you've considered
One could rename this variable to something else, in case it is desirable to define the
PREFIXmacro to one location and install the game to another. I see no reason why anyone would want to do this.Testing
Compiled and installed in Release mode. The game launches and plays fine.
Additional context
N/A