Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optimization downgrade for OSXCROSS #46083

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

This will re-enable optimization flags on OSX builds at the cost of rendering cross-compiled builds un-runnable on OSX versions prior to 10.11, which is far past EoL.
Fixes #45638

Describe the solution

Essentially revert #26564

This will re-enable optimization flags on OSX builds at the cost of rendering cross-compiled builds un-runnable on OSX versions prior to 10.11, which is far past EoL.
@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system labels Dec 16, 2020
@ZhilkinSerg ZhilkinSerg merged commit 3dd4cd6 into master Dec 17, 2020
@kevingranade kevingranade deleted the kevingranade-reoptimize-osx branch July 10, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments OS: macOS Issues related to macOS / OSX operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable Optimizations for macOS Builds
2 participants