Skip to content

Python linting updates and fixes #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

Python linting updates and fixes #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0a774e
lint: Drop versions of Python no longer supported by pylint 4.0.0
nathanchance Oct 14, 2025
4471535
lint: Test with Python 3.12, 3.13, and 3.14
nathanchance Oct 14, 2025
858534b
caching/check.py: Lower case HEADERS
nathanchance Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ['3.11', '3.10', '3.9', '3.8']
version: ['3.14', '3.13', '3.12', '3.11', '3.10']
uses: ClangBuiltLinux/actions-workflows/.github/workflows/python_lint.yml@main
with:
python_version: ${{ matrix.version }}
14 changes: 7 additions & 7 deletions caching/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
OWNER = "ClangBuiltLinux"
REPO = "continuous-integration2"
MAIN_BRANCH = "main"
HEADERS = {} # populated after args are parsed
headers = {} # populated after args are parsed

# states we allow our cache system to perform a cache-hit upon
# other states like 'presuite' or 'unknown' or '' (empty) are considered
Expand Down Expand Up @@ -94,7 +94,7 @@ def ___purge___cache___():
"""!!!completely clears the CBL CI cache!!!"""
list_url = f"https://api.github.com/repos/{OWNER}/{REPO}/actions/variables"

list_response = requests.get(list_url, headers=HEADERS, timeout=TIMEOUT)
list_response = requests.get(list_url, headers=headers, timeout=TIMEOUT)
print(list_response.content)
all_variables_keys = [
x["name"] for x in json.loads(list_response.content)["variables"]
Expand All @@ -106,7 +106,7 @@ def ___purge___cache___():
f"https://api.github.com/repos/{OWNER}/{REPO}/actions/variables/{key}"
)
delete_response = requests.delete(delete_url,
headers=HEADERS,
headers=headers,
timeout=TIMEOUT)
if delete_response.status_code != 204:
print(f"ERROR: Couldn't delete cache entry with key {key}")
Expand Down Expand Up @@ -136,7 +136,7 @@ def get_clang_version():
def get_repository_variable_or_none(name: str) -> Optional[dict]:
_url = f"https://api.github.com/repos/{OWNER}/{REPO}/actions/variables/{name}"

response = requests.get(_url, headers=HEADERS, timeout=TIMEOUT)
response = requests.get(_url, headers=headers, timeout=TIMEOUT)
if response.status_code != 200:
return None

Expand All @@ -156,14 +156,14 @@ def create_repository_variable(name: str, linux_sha: str, clang_version: str,
})
data = {"name": name, "value": _value}

resp = requests.post(_url, headers=HEADERS, json=data, timeout=TIMEOUT)
resp = requests.post(_url, headers=headers, json=data, timeout=TIMEOUT)
print(f"create_repository_variable() response:\n{resp.content}")


if __name__ == "__main__":
args = parse_args()

HEADERS = {
headers = {
"Accept": "application/vnd.github+json",
"Authorization": f"Bearer {args.github_token}",
"X-GitHub-Api-Version": "2022-11-28",
Expand Down Expand Up @@ -228,7 +228,7 @@ def create_repository_variable(name: str, linux_sha: str, clang_version: str,
""")
update_repository_variable(
VAR_NAME,
http_headers=HEADERS,
http_headers=headers,
sha=curr_sha,
clang_version=curr_clang_version,
patches_hash=curr_patches_hash,
Expand Down