Python linting updates and fixes #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a change in pylint 4.0.0 that changes how variable names are treated with regards to upper case versus regular snake case. At the same time, pylint 4.0.0 dropped support for versions of Python older than 3.10. In order to fix the warnings from 4.0.0, we need to drop versions of Python unsupported by 4.0.0 from the matrix, otherwise those versions would start warning because of the old variable name logic. Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
After pylint 4.0.0: caching/check.py:46:0: C0103: Variable name "HEADERS" doesn't conform to snake_case naming style (invalid-name) caching/check.py:166:4: C0103: Variable name "HEADERS" doesn't conform to snake_case naming style (invalid-name) Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
requested review from
JustinStitt,
bwendling and
nickdesaulniers
as code owners
nickdesaulniers
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change in pylint 4.0.0 that changes how variable names are treated with regards to upper case versus regular snake case. At the same time, pylint 4.0.0 dropped support for versions of Python older than 3.10. In order to fix the warnings from 4.0.0, we need to drop versions of Python unsupported by 4.0.0 from the matrix, otherwise those versions would start warning because of the old variable name logic.
Addresses the following new warnings from pylint 4.0.0 as spotted in CI: