-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use capnproto to serialize/deserialize #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharpener6
force-pushed
the
main
branch
5 times, most recently
from
August 19, 2024 18:19
7ad4519
to
48d2024
Compare
rafa-be
reviewed
Aug 21, 2024
rafa-be
reviewed
Aug 21, 2024
rafa-be
reviewed
Aug 21, 2024
rafa-be
reviewed
Aug 21, 2024
JamieSlome
reviewed
Aug 21, 2024
Signed-off-by: Jamie Slome <[email protected]>
Signed-off-by: Jamie Slome <[email protected]>
- Replace customized zmq frames serialization with Cap'n Proto to pave the road to implement language agnostic scheduler implementation, so make C++ implementation of scheduler feasible. - Replace legacy setup.py with pyproject.toml - Add configuration for black, flake8, and mypy - Change to monotonic time for profiling - Fix mypy warnings Signed-off-by: Sharpner6 <[email protected]>
rafa-be
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rafa-be
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note all the warnings for flake8/mypy need be fixed when contribute, also all test cases need passed