Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Run test suite and Linter as workflow #7

Closed
sharpener6 opened this issue Aug 19, 2024 · 3 comments
Closed

Enable Run test suite and Linter as workflow #7

sharpener6 opened this issue Aug 19, 2024 · 3 comments
Assignees

Comments

@sharpener6
Copy link
Collaborator

sharpener6 commented Aug 19, 2024

This will requires strict checking on PEP8 and mypy errors and of course all the unit test cases, please add following to actions, all the mypy/flake8 arguments should be defined in pyproject.toml:

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v4
      - name: Set up Python 3.8
        uses: actions/setup-python@v3
        with:
          python-version: "3.8"
      - name: Install dependencies
        run: |
          python -m pip install --upgrade pip
          pip install flake8 pyproject-flake8 mypy
          pip install -r requirements.txt
      - name: Lint with flake8
        run: |
          pflake8 .
      - name: Lint with MyPy
        run: |
          mypy .
      - name: Run python unittest
        run: |
          python -m unittest discover -v tests
@sharpener6 sharpener6 self-assigned this Aug 19, 2024
@JamieSlome
Copy link
Member

@sharpener6 - can we get a description for this issue? What are the requirements here?

@sharpener6
Copy link
Collaborator Author

Solve this along in #6

@sharpener6 sharpener6 changed the title Enable Run test suite Enable Run test suite and Linter as workflow Aug 19, 2024
@sharpener6
Copy link
Collaborator Author

@sharpener6 - can we get a description for this issue? What are the requirements here?

@JamieSlome , the #6 should along will solve this issue, can you review it? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants