Add pull_request trigger to CodeQL workflow#90
Merged
Conversation
Brings Try-Pattern's codeql.yaml in line with the canonical repo-template. Without this trigger, the CodeQL job did not run on pull requests, leaving the now-required 'Security Scan (CodeQL) (csharp)' status check perpetually expected and blocking all PR merges. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
pull_requesttrigger to.github/workflows/codeql.yaml, matching the canonicalrepo-template.This was missing in Try-Pattern only (audit confirmed all other repos had it). As a result, the now-required
Security Scan (CodeQL) (csharp)status check never ran on PRs and blocked all merges (e.g. #88, #89).Because this PR is itself a PR and the workflow file change only takes effect after merge, this PR will also hit the same blocking required-check problem.
To merge: temporarily remove
Security Scan (CodeQL) (csharp)from the required checks in theProtect main branchruleset, merge this PR, then re-add it. Once merged, future PRs will run CodeQL automatically and #88 / #89 will unblock.Test plan
Security Scan (CodeQL) (csharp)reports as a status check