Add .github/workflows/* to protected file detection#88
Merged
Conversation
Extends the trusted-config-fetch and protected-file-detect logic in pr.yaml to cover workflow files. PRs that modify any .yml/.yaml under .github/workflows/ now fail with the maintainer-review message, consistent with how .editorconfig, Directory.Build.*, BannedSymbols.txt, *.globalconfig, and *.ruleset are already handled. Defense in depth: even though pull_request_target sources the workflow from main (not the PR branch), failing loudly when workflow files are touched gives a clear maintainer signal regardless of the trigger model. Changes: - 4 bash 'Fetch trusted configuration files' steps: added 2 workflow glob patterns to config_files=() - 1 PowerShell 'Fetch trusted configuration files' step: added 2 patterns to $globPatterns - 1 'Detect protected configuration file changes' step: extended the grep regex to also match ^\.github/workflows/.*\.ya?ml$ Verified: YAML still parses cleanly (name='PR Checks v3 (Gated)', trigger='pull_request_target', 6 jobs). Regex tested against sample file paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The "Detect protected configuration file changes" step in `pr.yaml` already fails the build (with a maintainer-review message) if a PR modifies `.editorconfig`, `Directory.Build.props/.targets`, `BannedSymbols.txt`, `.globalconfig`, or `.ruleset`. This PR extends that protection to `.github/workflows/.yml`/`.yaml`.
Why it matters
`pull_request_target` already sources the workflow from `main`, so a malicious PR modifying `pr.yaml` on its branch can't actually take effect. But:
Failing fast on workflow modifications gives maintainers a clear "review this carefully" signal regardless of the trigger model.
Changes
Verification
🤖 Generated with Claude Code