ci(inspectcode): fix Run InspectCode step exit code 2 on Git Bash (Windows)

[Chris-Wolfgang]

Symptom

ReSharper InspectCode job on windows-latest exits with code 2 in the Run InspectCode step, with NO output between the ##[endgroup] and ##[error]Process completed with exit code 2 — a very fast failure that pre-empts the actual jb inspectcode call. Reproduced on PR #249's CI run.

Root cause

The step's first line under -e -o pipefail was:

SLN=$(ls *.slnx 2>/dev/null | head -n1)

On Git Bash for Windows (which is the shell after #248's runs-on: windows-latest switch), when there are no *.slnx files:

• ls *.slnx 2>/dev/null — glob doesn't match, ls reports the literal to stderr (silenced), exits 2 ("misuse")
• Piped to head -n1 — head returns 0 but pipefail carries ls's 2 through the pipe
• Command substitution inside SLN=$(...) — under set -e + pipefail, the entire step exits 2 before the if [ -z ] fallback line even runs

On ubuntu-latest bash the same pattern happened to be tolerated (subtle differences in how set -e propagates through $() on GNU bash), so nobody caught this until we switched runners.

Fix

Replace the ls | head pipeline with a direct glob-iteration loop:

SLN=""
for candidate in *.slnx *.sln; do
  if [ -f "$candidate" ]; then
    SLN="$candidate"
    break
  fi
done

No pipes, no ls, no pipefail interaction. Uniform behavior across Ubuntu bash and Git Bash on Windows.

Protected file

Only .github/workflows/pr.yaml. Detect .NET Projects will fail as expected → admin-bypass required.

Fleet impact

Same fix needed on the 4 downstream repos where #248 landed (AuditTrail #202, ETL-SqlBulkCopy #154, System.Mail-Extensions #209, console-app-template #291) AND the 14 open chore/add-inspectcode fleet PRs that now carry the same buggy block. I'll fold this into the same fan-out mechanism used earlier once merged.

[Copilot]

Pull request overview

Fixes a Windows/Git Bash-specific failure mode in the ReSharper InspectCode workflow step where set -e -o pipefail caused an early exit when no *.slnx file existed.

Changes:

• Replaced ls | head solution discovery with a pipe-free glob-iteration loop over *.slnx then *.sln.
• Added inline rationale documenting the Git Bash + pipefail interaction that produced exit code 2.