pr.yaml: use signed-by for focal-security instead of [trusted=yes]#70
Merged
Conversation
Addresses Copilot's review comment on repo-template#336: [trusted=yes] disables GPG verification entirely, which is a supply-chain risk. signed-by=/usr/share/keyrings/ubuntu-archive-keyring.gpg pins the focal-security source to the Ubuntu archive keyring that ships in the base runner image, so apt still verifies the libssl1.1 package signature. Validates the new approach before promoting to repo-template and the 18 downstream PRs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow to keep APT signature verification enabled while still allowing installation of libssl1.1 (needed for .NET 5.0) from Ubuntu focal-security on newer GitHub-hosted runners.
Changes:
- Replaces
deb [trusted=yes] ... focal-securitywithdeb [signed-by=/usr/share/keyrings/ubuntu-archive-keyring.gpg] ... focal-securityto avoid disabling signature verification. - Updates the inline workflow comments to reflect the new verification approach and rationale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
[trusted=yes](added in #69) with[signed-by=/usr/share/keyrings/ubuntu-archive-keyring.gpg]so apt still verifies thelibssl1.1package signature.Why
Copilot flagged
[trusted=yes]on repo-template#336:Valid concern.
signed-by=pins the focal-security source to the Ubuntu archive keyring that already ships in the base runner image (/usr/share/keyrings/ubuntu-archive-keyring.gpg) — keeping verification on while still working around the default-trusted-set issue that caused the original failure.Validation
This PR is the validation step. If CI goes green, the same change rolls forward to repo-template#336 and the 18 downstream PRs that already merged-in or are queuing the
[trusted=yes]version.