Skip to content

pr.yaml: add [trusted=yes] to focal-security apt source#69

Merged
Chris-Wolfgang merged 1 commit into
mainfrom
chore/fix-libssl1-apt-source
May 5, 2026
Merged

pr.yaml: add [trusted=yes] to focal-security apt source#69
Chris-Wolfgang merged 1 commit into
mainfrom
chore/fix-libssl1-apt-source

Conversation

@Chris-Wolfgang

Copy link
Copy Markdown
Owner

Summary

Adds `[trusted=yes]` to the `focal-security` apt source line in pr.yaml's "Install OpenSSL 1.1 for .NET 5.0" step.

Why

The step is currently failing on newer GitHub-hosted Ubuntu runners with:
```
E: Package 'libssl1.1' has no installation candidate
```

Root cause: the focal Ubuntu archive signing key is not always present on newer runner images. apt silently `Ign`'s the source (`Ign:55 ... focal-security InRelease`), `apt-get update` succeeds without it, so `libssl1.1` isn't in the package index when install runs.

`[trusted=yes]` skips GPG signature verification, letting the source be used regardless of key availability.

Testing approach

This is a "test in one repo first" change. If CI on this PR (or a re-run of #68) succeeds at the install step, propagate the fix to canonical `repo-template` and roll out to the other ~19 repos that have .NET 5.0 in their test matrix.

Note about CI on this PR itself

The PR uses `pull_request_target`, which runs the workflow from `main` (not from the PR branch). So this PR's own CI will run the unfixed step — and likely still fail. The fix only takes effect once it's on main. Validation will be by re-running an existing PR (e.g. #68) after this lands.

🤖 Generated with Claude Code

The 'Install OpenSSL 1.1 for .NET 5.0' step was failing on newer
GitHub-hosted Ubuntu runners with:

  E: Package 'libssl1.1' has no installation candidate

Root cause: the focal Ubuntu archive signing key is not always
present on newer runner images. apt silently Ign's the source
('Ign:55 ... focal-security InRelease') and apt-get update succeeds
without it, so libssl1.1 isn't in the package index when install
runs.

Adding [trusted=yes] to the apt source line skips signature
verification, letting the source be used regardless of key
availability.

Testing this fix locally before propagating to canonical and the
other ~19 affected repos.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 5, 2026 01:51
@Chris-Wolfgang Chris-Wolfgang merged commit 9d47b07 into main May 5, 2026
8 of 9 checks passed
@Chris-Wolfgang Chris-Wolfgang deleted the chore/fix-libssl1-apt-source branch May 5, 2026 01:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tries to restore the .NET 5.0 compatibility workaround in the PR workflow by changing how libssl1.1 is sourced from Ubuntu focal-security. In this template repo, that change affects the shared CI path used by downstream repositories created from the template.

Changes:

  • Adds [trusted=yes] to the temporary focal-security APT source used in the OpenSSL 1.1 install step.
  • Documents the runner-key issue that caused libssl1.1 to disappear from the package index on newer GitHub-hosted runners.

Comment thread .github/workflows/pr.yaml
Comment on lines +330 to 336
# [trusted=yes] skips GPG signature verification — the focal Ubuntu archive
# signing key is not always present on newer GitHub-hosted runners, which
# caused the apt source to be silently ignored and 'libssl1.1' to fail with
# 'has no installation candidate'.
echo "deb [trusted=yes] https://security.ubuntu.com/ubuntu focal-security main" | sudo tee /etc/apt/sources.list.d/focal-security.list
sudo apt-get update -q
sudo apt-get install --yes libssl1.1
Comment thread .github/workflows/pr.yaml
Comment on lines +330 to +334
# [trusted=yes] skips GPG signature verification — the focal Ubuntu archive
# signing key is not always present on newer GitHub-hosted runners, which
# caused the apt source to be silently ignored and 'libssl1.1' to fail with
# 'has no installation candidate'.
echo "deb [trusted=yes] https://security.ubuntu.com/ubuntu focal-security main" | sudo tee /etc/apt/sources.list.d/focal-security.list
This was referenced May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants