Repository navigation
ci(pr): gates that cannot run now fail instead of passing (#308) - #356
Open
Chris-Wolfgang wants to merge 1 commit into
Open
Chris-Wolfgang wants to merge 1 commit into
Chris-Wolfgang wants to merge 1 commit into
Conversation
Same change as repo-template / ICollection-Extensions #341: - InspectCode gate: set -euo pipefail; fail when inspect.sarif is missing or empty, when jq is absent, or when the count is not a number (it used to exit 0 with 'No findings' in all three cases). - Stage 2 (Windows): record the test assemblies that ran a coverage-collecting TFM; fail instead of skipping when tests ran but no coverage file appeared; new step requires a coverage row for every recorded assembly (Stage 1 already had both since #313). - inspectcode-upload tests the PR author, not github.actor, for Dependabot. Refs #308 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #308. Protected file only (
.github/workflows/pr.yaml). First PR of the CI series, stacked on the security PR #345 because the Dependabot series below it also editspr.yaml(merge #341 -> #342 -> #343 -> #344 -> #345 first). #308 needs a manual close after merge.Status of the three items in #308 on this repo, checked against
pr.yaml:set -euo pipefail, and explicit failures for a missing/emptyinspect.sarif, a missingjq, and a non-numeric count.*.Tests.Integration.*": already fixed on main (ci: sync Stage 1 coverage gate and build-pr.ps1 local tools from repo-template #313); the remaining exclusion is Stage 3 (macOS, no Docker) by design.Also:
inspectcode-uploadtests the PR author (github.event.pull_request.user.login) instead ofgithub.actorfor Dependabot, like every other Dependabot guard in the file.The file is ICollection-Extensions #341's (repo-template's)
pr.yaml; the only other difference between the two repos' files was theupload-sarifpin, kept at this branch's v4.39.0.Verification
Verified locally; CI blocked by the account billing lock.
actionlint -shellcheck=exit 0;zizmor --offlineno findings.run:steps syntax-checked (bash -n/ PowerShellParser::ParseFile): 0 failures.jqnot on PATH -> 1.CoverageReport/Summary.txtfrom a localbuild-pr.ps1run: real ledger (Unit, Fuzz, DocExamples) -> 0; a claimed-but-absentTests.Integrationrow -> 1; a name that is a prefix of a real row (...Tests) -> 1; empty ledger -> 1; missing ledger -> 1; missingSummary.txt-> 1.🤖 Generated with Claude Code