Repository navigation
fix(security): override semgrep's mcp pin to 1.30.0 (GHSA-84m7-p3x7-pcfv) - #345
Open
Chris-Wolfgang wants to merge 1 commit into
Open
Chris-Wolfgang wants to merge 1 commit into
Chris-Wolfgang wants to merge 1 commit into
Conversation
) semgrep 1.180.0 pins mcp==1.29.0, inside the vulnerable range of GHSA-84m7-p3x7-pcfv (Dependabot alerts #35 and #36). Add semgrep-overrides.txt with mcp>=1.30.0,<2 and regenerate semgrep.txt with --override; only mcp moves (1.29.0 -> 1.30.0). semgrep.yaml installs with --no-deps, and semgrep scan never imports mcp. Same approach as Hawsey #1009 and ICollection-Extensions #316. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Dependabot alerts #35 (
semgrep.txt) and #36 (semgrep.in): GHSA-84m7-p3x7-pcfv inmcp(unbounded session accumulation in the StreamableHTTP transport, fixed in 1.30.0).semgrep 1.180.0 pins
mcp==1.29.0, so neither Dependabot nor a plain recompile can move it. This PR:.github/requirements/semgrep-overrides.txtwithmcp>=1.30.0,<2and a comment saying why and when to delete it;semgrep.txtwithuv pip compile --universal --generate-hashes --override semgrep-overrides.txt semgrep.in -o semgrep.txt(header updated to the new command). Onlymcpmoves (1.29.0 -> 1.30.0); every other pin and hash is unchanged.semgrep.yamlinstalls withpip install --no-deps --require-hashes, so pip does not re-apply semgrep's own pin, andsemgrep scannever importsmcp(it is only used by semgrep's MCP server). Same approach as Hawsey #1009 and ICollection-Extensions #316. No decision on this alert had been recorded by the owner, so the fleet's override approach was adopted.Stacked on the Dependabot series top #344; merge #341 -> #342 -> #343 -> #344 first.
Verification
Verified locally; CI blocked by the account billing lock.
git diff:semgrep.txtchanges only the header line and themcpentry (+7/-5); new filesemgrep-overrides.txt.pip install --no-deps --require-hashes -r .github/requirements/semgrep.txt: succeeded; installedmcp 1.30.0,semgrep 1.180.0.semgrep scan --config p/csharp --config p/security-audit --config p/secrets --metrics=off src testswith that venv: exit 0, no findings.🤖 Generated with Claude Code