Skip to content

Release v0.8.1: canonical maintenance round + AssemblyVersion fix#112

Merged
Chris-Wolfgang merged 105 commits into
mainfrom
vNext
Jun 22, 2026
Merged

Release v0.8.1: canonical maintenance round + AssemblyVersion fix#112
Chris-Wolfgang merged 105 commits into
mainfrom
vNext

Conversation

@Chris-Wolfgang

@Chris-Wolfgang Chris-Wolfgang commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

Cuts v0.8.1. Supersedes the stacked canonical PRs (canonical-protected, canonical-unprotected, protected/d8-verify-docs-build-fleet, fix/restore-assemblyversion, chore/remove-post-setup-bootstrap-files) — all folded into this vNext → main merge.

Library public API and runtime behavior are unchanged from the previous release. This is canonical CI/docs/metadata work plus the C4 binding-stability fix.

Scope folded into v0.8.1

Added

  • D8 verify-docs-build job in release.yaml (deduplicated)
  • A1 PublicApiAnalyzers scaffolding (baseline file deferred to IDE-fix pass)
  • CI3 canonical NuGet metadata (Authors/Copyright/SourceLink/snupkg)
  • T3 Stryker mutation-testing workflow
  • T1 coverage report published to docs
  • S1 CodeQL security-extended query pack
  • D6 versions.json preservation guard
  • D7 docs build cache hygiene
  • docs/DOCFX-VERSION-PICKER.md (the D8 bulk fanout dropped this file on some repos; added directly)

Changed

  • C1 fleet template-drift sync
  • <Nullable>enable</Nullable> consolidated into Directory.Build.props
  • CI2 Dependabot github-actions ecosystem
  • D3 script hardening
  • Analyzer PackageReferences centralized in Directory.Build.props
  • Removed post-setup bootstrap files (scripts/setup.ps1, Setup-BranchRuleset.ps1, Setup-GitHubPages.ps1) — template carry-overs

Fixed

  • C4 restored explicit <AssemblyVersion>1.0.0.0</AssemblyVersion> + prerelease-safe <FileVersion> — binding stability for .NET Framework consumers
  • Duplicate verify-docs-build: job key in release.yaml
  • .gitattributes merge conflict resolved by keeping the canonical documented variant

Note: the previous version of this description listed P2 (BenchmarkDotNet → gh-pages chart workflow) under Added. There is no benchmark.yaml (or similar) workflow in this PR — only the existing build-all-versions/codeql/docfx/pr/release/stryker workflows. The benchmarks/ directory exists in this repo so P2 is a valid follow-up, but it is not in scope for v0.8.1.

Post-merge

  1. Tag v0.8.1 and publish GitHub Release → release.yaml fires
  2. Verify NuGet indexing
  3. Delete vNext + close any remaining superseded PRs

Chris-Wolfgang and others added 30 commits May 22, 2026 11:30
Template-drift resolution for ETL-Test-Kit — the non-protected half. Re-syncs
15 template-tracked infrastructure files to the canonical
repo-template. Excludes docfx_project/* (repo-specific docs), protected
config/workflow files (separate PR), and .gitkeep / expected-noise files.

Part of #72.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Template-drift resolution for ETL-Test-Kit — the protected half. 5 files
that trip the pr.yaml guard, isolated for admin-bypass merge.

Part of #72.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The C1 drift re-sync brought the canonical CONTRIBUTING.md but left the
template's {{PROJECT_NAME}} placeholder literal. Replace it with this repo's
project name so the synced CONTRIBUTING.md is correct, not a raw template.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Normalize to the package name for ETL-family consistency (the prior
commit fell back to the repo name because the local clone lacked a
single src/ project dir to derive from).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fold-down of the repo-template fix (PR #389): Replace-Placeholders now
writes with -Encoding utf8NoBOM -NoNewline. Rolled to every repo so the
campaign stays consistent with the updated canonical.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Propagates the three files folded into repo-template during drift Phase 0:
tests/Directory.Build.props + benchmarks/Directory.Build.props
(TreatWarningsAsErrors=false) and tests/.editorconfig (test-project analyzer
relaxations). Excluded from the initial C1 sync; rolled out now so every repo
matches the canonical template.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Removes the TreatWarningsAsErrors=false override on test projects. The
genuinely test-inappropriate analyzer rules are already silenced per-rule in
tests/.editorconfig; test code now inherits the root Directory.Build.props
(TreatWarningsAsErrors in Release, like src/examples). benchmarks remain
exempt for now.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add <Nullable>enable</Nullable> to the root Directory.Build.props and
remove the now-redundant per-project <Nullable> lines from every
SDK-style csproj. Nullable reference types are configured in one place;
a newly added project inherits the setting automatically.

Both halves ride this protected branch so they merge atomically — the
Directory.Build.props addition and the csproj removals land together,
so there is never a window where nullable reference types are off.

Legacy non-SDK project files do not import Directory.Build.props and
are left untouched with their explicit settings.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Legacy non-SDK .csproj files explicitly import Microsoft.Common.props,
so they DO inherit Directory.Build.props — the earlier unconditional
<Nullable>enable</Nullable> reached projects it should not have:

  * F# (.fsproj) / VB (.vbproj) projects — now excluded by conditioning
    the property on '$(MSBuildProjectExtension)' == '.csproj'.
  * legacy non-SDK C# example projects (C# 7.3, no nullable support) —
    given an explicit <Nullable>disable</Nullable> opt-out, restoring
    their pre-hoist state. These are the documented C5 carve-outs.

SDK-style C# projects are unaffected — they still inherit enable from
the single Directory.Build.props.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The explicit interface member declared 'object' but the non-generic
System.Collections.IEnumerator.Current is 'object?' in a nullable
context, so returning it tripped CS8603. Declare the member 'object?'
to match the interface.

Surfaced by holding test projects to TreatWarningsAsErrors (the
tests/Directory.Build.props drop) — a genuine latent bug, now fixed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds queries: security-extended to the CodeQL init step so the broader
security query pack runs on top of the default queries. Slightly longer
scans, materially more security coverage.

Initiative S1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
New .github/workflows/stryker.yaml runs Stryker.NET against the repo's
test projects on workflow_dispatch and a weekly schedule. The workflow
is a no-op until a stryker-config.json is added at repo root or under
tests/<project>/ — this commit is the canonical infrastructure;
per-repo Stryker config is the follow-up.

Initiative T3.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add a verify-docs-build job to release.yaml that runs DocFX without
deploying (metadata + build + output check). publish-nuget now needs
[pack-and-validate, verify-docs-build] so a broken docs build blocks
the release before the NuGet package goes live.

If a repo has no docfx_project/docfx.json, the job no-ops with a
notice; this is the canonical infrastructure, with per-repo docs
coverage tracked separately.

Initiative D8.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Append a github-actions package-ecosystem to .github/dependabot.yml so
Dependabot opens weekly PRs to bump pinned action versions in the repo's
GitHub workflows. Grouped under a single PR per week. Existing nuget
ecosystems are left unchanged.

Initiative CI2.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Keep-a-Changelog skeleton with an [Unreleased] section so release
notes can accumulate here between releases instead of being lost.
Follows the canonical format used across the fleet.

Initiative D3.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add a guard step to docfx.yaml that fetches the currently-deployed
versions.json from gh-pages and confirms the newly-generated one has
at least as many entries AND retains every previously-published version
label. Aborts the deploy if the version selector would shrink or lose
entries.

If no existing versions.json is found (first deploy), the step no-ops
with a notice.

Initiative D6.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add the Microsoft.CodeAnalysis.PublicApiAnalyzers package plus opt-in
AdditionalFiles globbing for PublicAPI.Shipped.txt / Unshipped.txt to
the root Directory.Build.props.

The AdditionalFiles use Exists() conditions, so the analyzer activates
per-project only when those files are present. Library projects opt in
by dropping the two text files into the src directory; test, example,
and benchmark projects stay dormant.

Per-repo enablement (populate Unshipped.txt with the current public API
surface) is tracked as a separate follow-up maintenance issue.

Initiative A1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add fleet-canonical defaults to root Directory.Build.props:

- Authors / Company / Copyright (uniform across the fleet; per-csproj
  values still win where set explicitly).
- RepositoryType=git, PublishRepositoryUrl=true.
- IncludeSymbols=true + SymbolPackageFormat=snupkg so .snupkg ships
  with every .nupkg.
- EmbedUntrackedSources=true to capture generated sources in PDBs.
- ContinuousIntegrationBuild=true under $(CI)=true (deterministic
  build flag, set by GitHub Actions).
- Microsoft.SourceLink.GitHub package so debuggers can step from
  NuGet-installed code straight to GitHub source.

Repo-specific NuGet fields (Description, PackageTags, PackageProjectUrl,
RepositoryUrl, PackageLicenseExpression, PackageReadmeFile) stay in
per-src csproj where they belong and are tracked as per-repo follow-up
maintenance issues.

Initiative CI3.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add a docfx.yaml step that runs the test suite with Cobertura coverage
collection and generates a ReportGenerator HTML report into
docfx_project/_site/coverage/ before the deploy step. The published
docs site gains a /coverage/ subpath alongside the existing /api/.

continue-on-error keeps a coverage failure from blocking the docs
deploy; if no test projects are present the step no-ops.

Initiative T1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- BannedSymbols.txt: replace {{PROJECT_NAME}} placeholder with the repo's
  package name (skipped on repo-template where the placeholder is the
  intended template artifact).
- docfx.yaml: 'exit 1' inside the deploy try-block changed to 'throw' so
  the outer finally always unsets the global http.extraheader token; added
  $LASTEXITCODE checks after git fetch / git worktree add / git init /
  git remote add so a setup failure surfaces a clear error.

Fan-out of the round-2 Copilot fixes verified against DateTime-Extensions
(#178 / #179 pilot).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- scripts/Setup-BranchRuleset.ps1: jq filter wrapped in '[ .[] | select() ]'
  so the output is always valid JSON even with multiple matches; gh stderr
  redirected to a temp file so it can't poison stdout.
- scripts/Fix-BranchRuleset.ps1: same stderr-isolation fix on the rulesets
  fetch (no more '2>&1' merge).
- scripts/Validate-DocsDeploy.sh: distinguish 'versions.json never created'
  from 'versions.json failed validation' in step 4 so the skip message
  reflects reality.
- .github/dependabot.yml: drop the stale 'dotnet' label (no longer in the
  Setup-Labels.ps1 taxonomy).
- REPO-INSTRUCTIONS.md: replace the stale label list (dependabot-*, dotnet)
  with the current Maintenance-framework labels Setup-Labels.ps1 actually
  creates.

IAsyncEnumerable-Extensions also gets README.md / CONTRIBUTING.md updated
to point at docs/README-FORMATTING.md since the root copy was removed by
the earlier D7 cleanup.

Fan-out of the round-2 Copilot fixes verified against DateTime-Extensions
(#178 pilot).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- .github/workflows/stryker.yaml: replace literal-in-array config detection
  with explicit [ -f ] checks. nullglob only drops words that look like
  globs (contain *, ?, [); the bare literal 'stryker-config.json' was
  preserved unconditionally, so the workflow would mark found=true and
  attempt to install Stryker even on repos with no config.
- actions/checkout@v4 -> @v6 and setup-dotnet@v4 -> @v5 for consistency
  with the rest of the fleet's workflows.

Fan-out of the round-2 Copilot fixes verified against DateTime-Extensions
(#181 pilot).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stryker.yaml lives under .github/workflows/*, which means it trips the
pr.yaml "Detect .NET Projects" guard the same way the rest of
canonical-protected does. Keeping T3 on its own branch would have meant
two admin-bypass merges per repo (canonical-protected -> main, then
t3-stryker -> main). Folding T3 in here collapses that to one bypass on
the way to release.

Merges origin/t3-stryker-mutation-testing into canonical-protected. The
existing per-repo T3 PR will be closed as superseded once this lands.
These scripts were run once when this repo was bootstrapped from
repo-template and are not needed afterward:

- scripts/setup.ps1                              (orchestrator for the others)
- scripts/Setup-Maintenance.ps1                  (created the Maintenance issues)
- scripts/Setup-BranchRuleset.ps1                (created the main branch ruleset)
- scripts/Setup-GitHubPages.ps1                  (bootstrapped gh-pages branch)
- scripts/templates/maintenance-parent-body.md   (template used by Setup-Maintenance)

repo-template keeps these files — they remain available there so any new
repo created from the template can still run them at bootstrap.

Recurring utilities are intentionally kept: Setup-Labels.ps1 (idempotent),
Fix-BranchRuleset.ps1, format.ps1, Validate-DocsDeploy.sh, build-pr.ps1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add '$(UsingMicrosoftNETSdk)' == 'true' to the existing .csproj-only
condition so the property only applies to SDK-style projects. Legacy
non-SDK csproj files no longer pick up <Nullable>enable</Nullable> by
inheritance; they would have to opt in explicitly.

Verified safe by piloting on IComparable-Extensions — full Release
build + 540-test run (54 tests x 10 TFMs) passed cleanly with the
tightened condition. Resolves the PR-#390 review thread that asked for
this addition.

The per-repo explicit <Nullable>disable</Nullable> opt-outs already in
place on Try-Pattern (examples/CSharp.DotNet462.Example) and D20-Dice
(examples/Net4.8/Example1-Console) become redundant but harmless under
this condition — they can be cleaned up later, or left as belt-and-
suspenders documentation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Brings the canonical Directory.Build.props in line with repo-template and
D20-Dice, which carry an explanatory comment above the <Nullable> line
describing what the .csproj + $(UsingMicrosoftNETSdk) condition excludes
and where the remaining opt-out path lives.

No behavior change — comment only.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
T3's stryker.yaml was cherry-picked carrying actions/upload-artifact@v4,
while pr.yaml/release.yaml/codeql.yaml all use @v7. Bumping for
consistency with the fleet's canonical action versions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The flag is a Windows-PowerShell-5.1-only switch; pwsh (PowerShell 7+)
treats it as unsupported and errors. The step runs under shell: pwsh, so
the call must omit it. (Already correct in the alternate path elsewhere
in this workflow — bringing this one in line.)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
`dotnet tool install -g` errors with a non-zero exit code if the tool is
already installed (common on self-hosted runners and after prior steps).
Even with stderr redirected, the exit code can break subsequent invocations.

Switch to update-or-install: try update first (succeeds if installed),
fall back to install if not. The step runs under shell: pwsh so the
pwsh 7 || operator is available.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Get-ChildItem -Filter '*.sln' missed .slnx solutions, causing the
restore/build warm-up to silently skip in repos using the newer
solution format (e.g. IComparable-Extensions). Switching to a filter
that accepts both extensions so DocFX gets a compiled solution to
extract metadata from.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Chris-Wolfgang and others added 13 commits May 25, 2026 17:04
….Xunit

Activates the PublicApiAnalyzer that has been scaffolded but silent
since A1 landed. Initial Shipped.txt captures the current public surface,
frozen as the v0.x baseline. Unshipped.txt is empty header-only.

Posture: v0.x baseline. Future PRs that change public API will show
diffs in Unshipped.txt (additions) or move Shipped entries to Unshipped
with *REMOVED* markers (deletions). Pre-1.0 the diff is informational —
surface intentional vs accidental change — and becomes a stability
contract post-1.0.

Build verified clean across all TFMs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…esets

Fixes two bugs in the canonical-unprotected scripts that were fanned out
from repo-template:

- Setup-Labels.ps1: the ValidatePattern attribute string was left
  unterminated and the [string]$Repository declaration + closing paren
  were dropped, leaving a duplicated script body that ran with
  $Repository unbound. Param block restored to a single well-formed
  declaration; duplicated body removed.

- Fix-BranchRuleset.ps1: gh api --paginate concatenates multiple JSON
  array payloads when results span pages, which breaks ConvertFrom-Json.
  Switched to ?per_page=100 in a single call.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Stage 2 (Windows) coverage gate regex

    ^\s*(\S+)\s+.*(\d+(?:\.\d+)?)%\s*$

had a greedy `.*` between the module name and the trailing `\d+%`,
which ate all but the last digit of the percent. On lines like

    Wolfgang.Extensions.<X>                         100%

the regex captured percent=0 (the last "0" of "100"), reported the
module as failing the 90% threshold, and tanked the entire gate even
on 100%-covered code. First surfaced on DateTime-Extensions vNext —
PR #189 has the original fix.

Two changes to align with Stage 1 (Linux), whose awk-based parser is
correct:

- Anchor on `^(\S+)` to skip indented sub-class rows (Stage 1's
  `^[^ ]` does the same — assembly rows carry the aggregate
  percent, so nothing is lost).

- Drop the `.*`; let `\s+` separate the module from the final
  `\d+%` directly, so there is no greedy region to swallow digits.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Every shippable src csproj across the fleet had `<AssemblyVersion>1.0.0</AssemblyVersion>`
hardcoded — last touched at v1.0.0 and never bumped. Released NuGet
packages from v1.1.0 onward have shipped with AssemblyVersion=1.0.0
even though the package <Version> bumped normally.

Drop the explicit AssemblyVersion line. .NET SDK derives AssemblyVersion,
FileVersion, and InformationalVersion from <Version> when they are not
specified, so all four track every <Version> bump automatically going
forward. They are not byte-identical — AssemblyVersion is normalized to
a 4-part System.Version, InformationalVersion can carry a +<git-sha>
under SourceLink — but they all reflect the current Version, which is
the point.

Mirrors DateTime-Extensions PR #184 (already merged to main).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…> in src/Wolfgang.Etl.TestKit/Wolfgang.Etl.TestKit.csproj (C4 fix)
…> in src/Wolfgang.Etl.TestKit.Xunit/Wolfgang.Etl.TestKit.Xunit.csproj (C4 fix)
Copilot AI review requested due to automatic review settings June 1, 2026 02:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Maintenance release work for v0.8.1 that centralizes repository metadata/analyzer configuration, hardens CI/docs workflows, and fixes assembly/file versioning for package binding stability.

Changes:

  • Bumps source package versions to 0.8.1, pins AssemblyVersion to 1.0.0.0, and derives FileVersion from package version.
  • Adds/updates canonical CI, DocFX, CodeQL, Stryker, Dependabot, docs, formatting, and validation infrastructure.
  • Removes template setup carry-over scripts and reorganizes test analyzer configuration.

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
Directory.Build.props Centralizes nullable, analyzer packages, SourceLink, and NuGet metadata defaults.
src/Wolfgang.Etl.TestKit/Wolfgang.Etl.TestKit.csproj Bumps package version and pins assembly/file version metadata.
src/Wolfgang.Etl.TestKit.Xunit/Wolfgang.Etl.TestKit.Xunit.csproj Applies the same package/version metadata changes for the xUnit package.
tests/Wolfgang.Etl.TestKit.Tests.Unit/Wolfgang.Etl.TestKit.Tests.Unit.csproj Removes local nullable setting to inherit from root props.
tests/Wolfgang.Etl.TestKit.Xunit.Tests.Unit/Wolfgang.Etl.TestKit.Xunit.Tests.Unit.csproj Removes local nullable setting to inherit from root props.
tests/Wolfgang.Etl.TestKit.Tests.Unit/TestExtractorTests.cs Updates explicit non-generic enumerator Current nullability.
tests/Directory.Build.props Removes prior test-wide analyzer suppression props.
tests/.editorconfig Adds test-project analyzer severity overrides.
.github/workflows/pr.yaml Hardens PR validation, config restore, test discovery, workload restore, and coverage parsing.
.github/workflows/release.yaml Adds docs-build verification before publishing and uploads snupkg artifacts.
.github/workflows/docfx.yaml Reworks DocFX deploy/version preservation, coverage publishing, and gh-pages hygiene.
.github/workflows/codeql.yaml Enables security-extended queries and gated workload restore.
.github/workflows/build-all-versions.yaml Adds .slnx support and filters docs version entries to built tags.
.github/workflows/stryker.yaml Adds scheduled/manual Stryker mutation testing infrastructure.
.github/dependabot.yml Adds GitHub Actions updates and adjusts labels.
.github/pull_request_template.md Adds maintenance-task linking guidance.
.github/ISSUE_TEMPLATE/maintenance-task.yaml Adds a maintenance task issue form.
scripts/Validate-DocsDeploy.sh Adds gh-pages deployment validation script.
scripts/Fix-BranchRuleset.ps1 Adds ruleset repair script.
scripts/build-pr.ps1 Aligns local PR build/test/coverage/security behavior with CI.
scripts/format.ps1 Makes formatting script run from repo root regardless of caller cwd.
scripts/Setup-Labels.ps1 Updates canonical labels for dependencies and maintenance workflow.
scripts/setup.ps1 Removes obsolete template setup script.
scripts/Setup-GitHubPages.ps1 Removes obsolete GitHub Pages setup script.
REPO-INSTRUCTIONS.md Updates setup instructions after removing automated template scripts.
CONTRIBUTING.md Updates analyzer, SDK, and formatting guidance.
CHANGELOG.md Adds a Keep-a-Changelog scaffold.
docs/DOCFX-VERSION-PICKER.md Documents the DocFX version picker implementation and recovery flow.
docs/WORKFLOW_SECURITY.md Documents workflow files as protected configuration.
docs/RELEASE-WORKFLOW-SETUP.md Fixes Actions troubleshooting link text.
docs/README-FORMATTING.md Updates SDK and LF line-ending formatting guidance.
.gitattributes Clarifies LF handling for PowerShell scripts.
.editorconfig Clarifies PowerShell LF/UTF-8 inheritance comments.
BannedSymbols.txt Removes trailing blank line.

Comment thread scripts/Fix-BranchRuleset.ps1 Outdated
Comment thread tests/.editorconfig
Comment thread CHANGELOG.md
Comment thread REPO-INSTRUCTIONS.md Outdated
Comment thread Directory.Build.props
Comment thread REPO-INSTRUCTIONS.md Outdated
Comment thread .github/workflows/pr.yaml Outdated
Comment thread .github/workflows/pr.yaml Outdated
Comment thread REPO-INSTRUCTIONS.md Outdated
Comment thread .github/workflows/docfx.yaml
Nine of ten comments addressed:

- CHANGELOG.md: add a 0.8.1 entry listing what's actually in the
  release (was empty under [Unreleased]).
- REPO-INSTRUCTIONS.md:
  - Fix the release-trigger description: workflow triggers on
    `release: published`, not a tag push.
  - Fix the gh-pages create-branch one-liner: an orphan branch has
    no commits, so `git rm -rf . && git commit --allow-empty &&
    git push -u origin gh-pages` is required.
  - Fix the docfx file-path table: docfx.json and logo.svg live
    under docfx_project/, not at the repo root.
- tests/.editorconfig: add `CA1707.severity = none`. The previous
  test-wide suppression was removed by the canonical sync, but test
  methods use the `MethodUnderTest_when_condition_expected_result`
  underscore-naming convention and the root .editorconfig now
  elevates CA1707 to error.
- scripts/Fix-BranchRuleset.ps1: stop calling the retired
  Setup-BranchRuleset.ps1 (removed in this PR). Always print
  manual-recreation guidance instead of silently warning when the
  script isn't found — the warning path was always going to fire.
- .github/workflows/pr.yaml: capture `git show` output and check
  $LASTEXITCODE before writing. Previously `git show | Out-File`
  swallowed the exit code, so a failed fetch from main-branch left
  the PR-supplied protected config in place — defeating the
  hardening purpose. Applies to both the single-file and globbed
  branches.

The tenth comment (Directory.Build.props PublicApiAnalyzers
"unconditional package reference") is being left open for
discussion — the package ref is unconditional but the analyzer is
gated on `<AdditionalFiles Exists()/>`, so it produces zero
diagnostics for projects without PublicAPI.*.txt files. The
practical opt-in semantics work; will discuss whether to make the
package reference itself conditional in a follow-up.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Chris-Wolfgang and others added 2 commits June 20, 2026 21:48
Consume the canonical maintenance fixes shipped in Abstractions v0.13.1
(now on NuGet). Non-breaking: Abstractions 0.13.0 -> 0.13.1 is a
docs/metadata PATCH with no public API change, so TestKit stays a PATCH
(0.8.1). Verified: Release build clean, 253 tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	.github/workflows/docfx.yaml
#	docs/DOCFX-VERSION-PICKER.md
#	src/Wolfgang.Etl.TestKit.Xunit/Wolfgang.Etl.TestKit.Xunit.csproj
#	src/Wolfgang.Etl.TestKit/Wolfgang.Etl.TestKit.csproj
@Chris-Wolfgang Chris-Wolfgang merged commit 16cef8f into main Jun 22, 2026
8 checks passed
@Chris-Wolfgang Chris-Wolfgang deleted the vNext branch June 22, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants