build: TFM-warning + slnx + PublicAPI hygiene#181
Merged
Conversation
…rt PublicAPI.Unshipped Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # src/Wolfgang.Etl.TestKit.Xunit/PublicAPI.Unshipped.txt
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three build-hygiene fixes from the code review.
(a) netcoreapp3.1 TFM-support warnings
Both test projects list
netcoreapp3.1in<TargetFrameworks>but theirSuppressTfmSupportBuildWarningsPropertyGroups only covered net4x and net5/6/7. Extended the net5/6/7 PropertyGroupConditionin each to also matchnetcoreapp3.1. The 6 TFM-support warnings (3 TFMs × 2 test projects) are now gone.(b) Stale
.slnxreferencesRemoved solution-file references to files that no longer exist, and fixed one wrong extension:
REPO-INSTRUCTIONS.md.github/version-picker-template.htmlscripts/Setup-BranchRuleset.ps1scripts/Setup-GitHubPages.ps1.github/workflows/codeql.yml→.github/workflows/codeql.yaml(the real file)Each removed path was confirmed missing; the corrected
codeql.yamlconfirmed present.(c) PublicAPI.Unshipped sort
PublicAPI.Unshipped.txtin bothsrcprojects was not canonically sorted. Re-sorted each ordinally (matchingPublicAPI.Shipped.txt's convention) with the#nullable enableheader preserved as the first line.Verification
dotnet build ETL-Test-Kit.slnx -c Release→ 0 Warning(s), 0 Error(s) (TFM warnings gone, no RS0016/RS0017/RS0024/RS0025).Stack
Based on
fix/changelog(PR #180).🤖 Generated with Claude Code