Repository navigation
test: fix the four open InspectCode alerts in test code - #584
Open
Chris-Wolfgang wants to merge 1 commit into
Open
Chris-Wolfgang wants to merge 1 commit into
Chris-Wolfgang wants to merge 1 commit into
Conversation
- FixedWidthItemErrorHandlingTests: index the last progress report instead of Enumerable.Last() on a List (S6608, alerts 1526/1527). - SourceLinkPdbTests: drop the inferable tuple name `Name:` (RedundantExplicitTupleComponentName, alert 1529). - ConcurrencyStressTests: compare (Exception, Status) as one tuple in Assert.All so the lambda parameter is not only used by assertion preconditions (ParameterOnlyUsedForPreconditionCheck.Local, alert 1525). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Chris-Wolfgang
force-pushed
the
fix/inspectcode-s6608-error-handling-tests
branch
from
November 7, 2026 07:53
da32639 to
3f91802
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the four InspectCode code-scanning alerts open on
main(all in test code).Addresses #573, #574, #575 and #577. This PR is stacked on #583, so it does not auto-link them; they need closing by hand once this reaches
main.Test-code change - please review. No production code is touched.
FixedWidthItemErrorHandlingTests: readreports[reports.Count - 1]once instead ofreports.Last()twice (works on every TFM, including net462)SourceLinkPdbTests:(Name: entry.Name, ...)->(entry.Name, ...)ConcurrencyStressTests.RunFanoutAsync: theAssert.Alllambda now does oneAssert.Equalon(Exception, Status)against(null, RanToCompletion). Same checks, and the failure message still shows each failing iteration's exception and statusStack: #583 (mcp override) <- this PR (top of the security series).
Verified locally (Windows, .NET 10 SDK)
jb inspectcode "ETL Fixed Width.slnx" --include=<the 3 files> --severity=WARNING --format=Sarif: 0 results (all three files were inspected).dotnet build tests/Wolfgang.Etl.FixedWidth.Tests.Unit -c Release(all 13 TFMs): 0 warnings, 0 errors.dotnet testnet10.0:FixedWidthItemErrorHandlingTests9/9,Tests.Concurrency5/5,Tests.SourceLink3/3 passed.Not verified
🤖 Generated with Claude Code