Skip to content

fix: Stage 1 coverage gate mis-parses per-class rows (unblocks release #406) #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris-Wolfgang merged 1 commit into from
Aug 17, 2026
Merged

fix: Stage 1 coverage gate mis-parses per-class rows (unblocks release #406) #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,12 @@ jobs:
threshold=${CODECOV_MINIMUM:-90}
matched_count=0

while read -r line; do
# IFS= so `read` preserves leading whitespace — otherwise ReportGenerator's
# indented per-class rows are un-indented before the `^[^ ]` module filter
# sees them and get gated as if they were assemblies (#386). Only bites once
# test assemblies are instrumented (IncludeTestAssembly); Stage 2's pwsh
# parser is unaffected.
while IFS= read -r line; do
# Match lines with module names and percentages. The percent
# capture is the LAST %-suffixed number on the line, matching
# Stage 2's behavior — ReportGenerator Summary.txt rows often
Expand Down
Loading