fix: Stage 1 coverage gate mis-parses per-class rows (unblocks release #406) - #408
Merged
Merged
Conversation
'while read' strips leading whitespace, so ReportGenerator's indented per-class rows are un-indented before the '^[^ ]' module filter and get gated as assemblies — sub-90% classes fail a gate meant to check modules only. Bites now that test assemblies are instrumented (#386). Use 'while IFS= read'. (The 0.23.1 release PR #406 is blocked on this; #407 shipped the benchmark-workflow fixes but this pr.yaml change was orphaned by a concurrent merge.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the 0.23.1 release (#406). The Stage 1 coverage gate uses
while readwhich strips leading whitespace, so ReportGenerator's indented per-class rows get un-indented before the^[^ ]module filter and are gated as if they were assemblies. Sub-90% classes then fail a gate that should only check modules (overall coverage is 99.2%; every module is >90%). Invisible until #386 instrumented the test assemblies. One-char-class fix:while IFS= read.This is the #386 Stage-1 parse fix. It was in #407 but orphaned by a concurrent merge; re-doing it standalone. Protected file → admin-bypass. After merge, re-run #406's checks (Stage 1 will pass) and sync main→vNext so #406 shows no protected diff.
🤖 Generated with Claude Code