chore(security): InspectCode noise-floor .DotSettings — structural FPs only (#361) - #383
Merged
Merged
Conversation
Re-audit of the dismissed long-tail found this was a real dead-code finding, not a won't-fix: CapturingExtractor stored intervalMs in _intervalMs but never read it (ReportingInterval is set from the ctor param directly). Removed the field. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s only (#361) Adds a ReSharper InspectCode noise-floor limited to inspections that are STRUCTURALLY always false-positive for this repo (12 entries): - RS0016/RS0036/RS0037 — InspectCode runs PublicApiAnalyzers without the PublicAPI.*.txt AdditionalFiles; the in-build analyzer emits zero. - 7 nullable "…AccordingToAPIContract" rules — R# flags the base library's deliberate defensive null-checks; intentional for a lib called from nullable-oblivious / older-TFM code. - UnusedAutoPropertyAccessor.Global — R# can't see a library's external consumers. - MA0158 — System.Threading.Lock is net9.0+; multi-TFM floor requires object locks. Deliberately EXCLUDES the broader suppression set from the parallel #361 draft (#378): fixable style/correctness rules (RCS1102, S2930, S1939, xUnit1030, Redundant*, unused-variable/dead-field, S4456, S125, …) are FIXED in code on the vNext cleanup stack, location-specific intentional patterns are dismissed per instance with a reason, and S2068 (hard-coded credentials, a security rule) is NOT blanket-silenced. See the #378 reconciliation comment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4 tasks
Chris-Wolfgang
changed the base branch from
fix/inspectcode-longtail-cref
to
vNext
August 14, 2026 20:27
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR 8 (final) on the Code Scanning cleanup. Base:
fix/inspectcode-longtail-cref(PR #380). Closes #361.What
A ReSharper InspectCode noise-floor
.DotSettingslimited to structurally-always-FP inspections (12 entries): theRS0016/36/37PublicAPI trio (InspectCode runs the analyzer without thePublicAPI.*.txtbaseline), the 7 nullable-…AccordingToAPIContractrules (defensive base-lib null-checks),UnusedAutoPropertyAccessor.Global(library has external consumers), andMA0158(Lockis net9+).Relationship to #378
This supersedes the
.DotSettingsfrom the parallel #361 draft (#378). #378's version blanket-suppressed ~45 rules including many that are fixable (RCS1102,S2930,S1939,xUnit1030,Redundant*, unused-variable/dead-field,S4456,S125) and evenS2068(hard-coded credentials — a security rule). Those should not be silenced — they're fixed in code by this vNext stack (#370–#380) or dismissed per instance with a reason (so future genuine occurrences still surface). #378's code changes fully duplicate this stack (sameStaticMemberInGenericTypeholder,S2699,S4487, cref fixes — verified full-matrix here). See the reconciliation comment on #378.Notes
*.sln.DotSettingsis not a protected file — no admin-bypass needed.jb inspectcodeauto-loads this solution-adjacent file, so the suppressions apply in CI (thepr.yamlInspectCode job) exactly as documented in that workflow's "tune the noise floor via .DotSettings" comment.🤖 Generated with Claude Code