Repository navigation
test: fix broken XML-doc cref + triage the InspectCode long-tail - #380
Merged
Merged
Conversation
InvalidXmlDocComment: `EtlPipeline.From{T,TProgress}(...)` did not resolve —
`From` is an extension method declared on `EtlPipelineSourceExtensions`, not a
member of `EtlPipeline`. Point the cref at the extensions class with the `this`
parameter type included.
(The other long-tail InspectCode findings are false-positive / won't-fix in a
multi-TFM or test/benchmark context and are dismissed in code scanning: the
benchmark `<see cref="Pipeline"/>` resolves in code, S1215 GC.Collect in an
allocation test, S1994 intentional infinite loops, S6966 Cancel() required on
net462, MA0158 Lock is net9+, S5034 sync fuzz callback, etc.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Aug 14, 2026
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR 7 (final) on the Code Scanning cleanup — the misc long-tail. Base:
fix/inspectcode-correctness-examples(PR #377).Fix — 1 real issue
InvalidXmlDocCommentinEtlPipelineTests/TestDoubles.cs:EtlPipeline.From{T,TProgress}(...)didn't resolve becauseFromis an extension method onEtlPipelineSourceExtensions, not a member ofEtlPipeline. Repointed the cref at the extensions class (with thethisparam type).The rest of the long-tail — dismissed (false-positive / won't-fix)
After a fresh
jb inspectcodeon the fully-fixed branch, the remaining dashboard findings were triaged; 14 are code-correct / warning-wrong or platform-constrained and dismissed in code scanning:S1215 ×2—GC.Collect()is required in an allocation-measurement test beforeGC.GetTotalAllocatedBytes.S1994 ×3— intentional infinitefor(;;)/while(true)(infinite generators, retry-until-exhausted).S6966 ×2—cts.Cancel()required;CancelAsync()is net8+ only, base targets net462+.MA0158—System.Threading.Lockis net9+; multi-TFM type keepsobjectlock.S5034—ValueTaskblocked in CsCheck's synchronous fuzz callback (can't be async).S3267— loop kept to avoid LINQ allocation on the middleware-chain path.RCS1194/S4487/S6608— test-only boilerplate / scaffolding / immaterial micro-opt.InvalidXmlDocComment(benchmark) —<see cref="Pipeline"/>resolves in code (ReSharper FP).Not in this PR (already fixed upstream in the stack, clear at release):
StaticMemberInGenericType ×3+S2699 ×2(#376).Verification
Test project builds green (net8.0); doc-comment-only change.
🤖 Generated with Claude Code