refactor: EtlPipeline.From as extension method + fix InspectCode (MA0049/S2325) - #282
Merged
Merged
Conversation
…cleanup Class-named source/sink factories in format packages open files/connections the caller did not hand them. DisposingOwned wraps a sink to dispose those factory-owned resources after RunAsync (success or failure), preferring IAsyncDisposable and falling back to IDisposable, in reverse (LIFO) order — so packages don't each reimplement the decorator. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two InspectCode findings blocking #278 (vNext→main):
EtlPipelineTests→EtlPipelineCoreTests.Fromdidn't use theEtlPipelineinstance → moved bothFromoverloads into a newEtlPipelineSourceExtensionsstatic class asthis EtlPipelineextension methods. Extension methods are static (satisfies S2325) yet instance-callable, soCreate().From(...)is preserved andFromis now the same shape as the format-package source factories.Bodies unchanged;
PublicAPI.Shipped.txtupdated. src clean across all TFMs, 282 tests pass, Example8 (both TFMs) builds.Merge this → vNext → #278 re-runs and InspectCode should pass → then #278 → main → re-cut v0.16.0.