Skip to content

Fix MA0046 and S1133 analyzer errors on Windows TFMs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris-Wolfgang merged 2 commits into from
Mar 28, 2026
Merged

Fix MA0046 and S1133 analyzer errors on Windows TFMs #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3c2196
Fix MA0046 and S1133 analyzer errors on Windows TFMs
Chris-Wolfgang Mar 28, 2026
c5331ac
Disable TreatWarningsAsErrors for tests and examples
Chris-Wolfgang Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions examples/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)..'))" />
<PropertyGroup>
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
</PropertyGroup>
</Project>
2 changes: 2 additions & 0 deletions src/Wolfgang.Etl.Abstractions/IProgressTimer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ public interface IProgressTimer : IDisposable
/// Raised at each timer interval. Subscribers receive progress notifications
/// and should call <c>CreateProgressReport()</c> then <c>Report()</c>.
/// </summary>
#pragma warning disable MA0046 // Elapsed intentionally uses Action (not EventHandler) — changing the delegate signature would be a breaking change across all downstream ETL libraries
event Action? Elapsed;
#pragma warning restore MA0046

/// <summary>
/// Starts the timer with the specified interval in milliseconds.
Expand Down
12 changes: 0 additions & 12 deletions src/Wolfgang.Etl.Abstractions/Report.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,4 @@ public Report(int currentItemCount)
/// The number of items that have been processed so far in the ETL process.
/// </summary>
public int CurrentItemCount { get; }



/// <summary>
/// The number of items that have been processed so far in the ETL process.
/// </summary>
/// <remarks>
/// This property is obsolete. Use <see cref="CurrentItemCount"/> instead.
/// </remarks>
[Obsolete("Use CurrentItemCount instead. CurrentCount will be removed in a future version.")]
public int CurrentCount => CurrentItemCount;

}
6 changes: 3 additions & 3 deletions src/Wolfgang.Etl.Abstractions/Wolfgang.Etl.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net462;net472;net48;net481;netstandard2.0;netcoreapp3.1;net5.0;net6.0;net7.0;net8.0;net9.0;net10.0</TargetFrameworks>
<TargetFrameworks>net462;net472;net48;net481;netstandard2.0;net5.0;net6.0;net7.0;net8.0;net9.0;net10.0</TargetFrameworks>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<Version>0.11.0</Version>
<Version>0.12.0</Version>
<GeneratePackageOnBuild>False</GeneratePackageOnBuild>
<Title>$(AssemblyName)</Title>
<Authors>Chris Wolfgang</Authors>
Expand Down Expand Up @@ -53,7 +53,7 @@
get a full reference. The net8+ group pins the version with ExcludeAssets="runtime" to
prevent NuGet from resolving an older transitive version — no runtime assembly is copied.
-->
<ItemGroup Condition="'$(TargetFramework)' == 'net462' OR '$(TargetFramework)' == 'net472' OR '$(TargetFramework)' == 'net48' OR '$(TargetFramework)' == 'net481' OR '$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'netcoreapp3.1' OR '$(TargetFramework)' == 'net5.0' OR '$(TargetFramework)' == 'net6.0' OR '$(TargetFramework)' == 'net7.0'">
<ItemGroup Condition="'$(TargetFramework)' == 'net462' OR '$(TargetFramework)' == 'net472' OR '$(TargetFramework)' == 'net48' OR '$(TargetFramework)' == 'net481' OR '$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'net5.0' OR '$(TargetFramework)' == 'net6.0' OR '$(TargetFramework)' == 'net7.0'">
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="10.0.5" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'net8.0' OR '$(TargetFramework)' == 'net9.0' OR '$(TargetFramework)' == 'net10.0'">
Expand Down
6 changes: 6 additions & 0 deletions tests/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)..'))" />
<PropertyGroup>
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
</PropertyGroup>
</Project>
11 changes: 0 additions & 11 deletions tests/Wolfgang.Etl.Abstractions.Tests.Unit/ReportTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,6 @@ public void CurrentItemCount_returns_the_value_passed_to_the_constructor()



#pragma warning disable CS0618
[Fact]
public void CurrentCount_returns_the_same_value_as_CurrentItemCount()
{
var sut = new Report(7);
Assert.Equal(sut.CurrentItemCount, sut.CurrentCount);
}
#pragma warning restore CS0618



[Fact]
public void Two_Report_instances_with_same_value_are_equal()
{
Expand Down
Loading