Fix MA0046 and S1133 analyzer errors on Windows TFMs#115
Merged
Chris-Wolfgang merged 2 commits intomainfrom Mar 28, 2026
Merged
Fix MA0046 and S1133 analyzer errors on Windows TFMs#115Chris-Wolfgang merged 2 commits intomainfrom
Chris-Wolfgang merged 2 commits intomainfrom
Conversation
Suppress MA0046 on IProgressTimer.Elapsed (changing Action to EventHandler would be a breaking change across all downstream ETL libraries). Remove obsolete Report.CurrentCount property and its test. Bump version to 0.12.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The root Directory.Build.props enables TreatWarningsAsErrors in Release, which the CI Windows build applies to the entire solution. The .editorconfig suppressions for tests/ and examples/ are not reliably picked up on CI, causing 441 analyzer errors. Nested Directory.Build.props files in tests/ and examples/ import the root props and override TreatWarningsAsErrors to false, keeping it active only for src/ projects. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IProgressTimer.Elapsed— changingActiontoEventHandlerwould break all downstream ETL librariesReport.CurrentCountproperty (replaced byCurrentItemCount)CurrentCountremoved)Context
The new
pr.yamlworkflow (merged in #113) now builds all TFMs on Windows in Release mode, surfacing these pre-existing analyzer warnings as errors. This blocks PR #114 and any other open PR.Test plan
dotnet build --configuration Release— 0 warnings, 0 errors across all TFMsdotnet test --configuration Release— 132 tests pass🤖 Generated with Claude Code