Optimize boolean filter SQL generation for non-nullable bool fields

src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/Boolean/QueryableBooleanEqualsHandler.cs

@@ -21,6 +21,14 @@ public override Expression HandleOperation(
         object? parsedValue)
     {
         var property = context.GetInstance();
+
+        if (parsedValue is bool boolValue && property.Type == typeof(bool))
+        {
+            return boolValue
+                ? property
+                : FilterExpressionBuilder.Not(property);
+        }
+
         return FilterExpressionBuilder.Equals(property, parsedValue);
     }
 

src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/Boolean/QueryableBooleanNotEqualsHandler.cs

@@ -21,6 +21,14 @@ public override Expression HandleOperation(
         object? parsedValue)
     {
         var property = context.GetInstance();
+
+        if (parsedValue is bool boolValue && property.Type == typeof(bool))
+        {
+            return boolValue
+                ? FilterExpressionBuilder.Not(property)
+                : property;
+        }
+
         return FilterExpressionBuilder.NotEquals(property, parsedValue);
     }
 

src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorBooleanTests.Create_BooleanEqual_Expression.snap

@@ -13,11 +13,9 @@ true Result:
 
 true SQL:
 ---------------
-.param set @__p_0 1
-
 SELECT "d"."Id", "d"."Bar"
 FROM "Data" AS "d"
-WHERE "d"."Bar" = @__p_0
+WHERE "d"."Bar"
 ---------------
 
 false Result:
@@ -35,9 +33,7 @@ false Result:
 
 false SQL:
 ---------------
-.param set @__p_0 0
-
 SELECT "d"."Id", "d"."Bar"
 FROM "Data" AS "d"
-WHERE "d"."Bar" = @__p_0
+WHERE NOT ("d"."Bar")
 ---------------

src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorBooleanTests.Create_BooleanEqual_Expression_NET10_0.snap

@@ -13,11 +13,9 @@ true Result:
 
 true SQL:
 ---------------
-.param set @p 1
-
 SELECT "d"."Id", "d"."Bar"
 FROM "Data" AS "d"
-WHERE "d"."Bar" = @p
+WHERE "d"."Bar"
 ---------------
 
 false Result:
@@ -35,9 +33,7 @@ false Result:
 
 false SQL:
 ---------------
-.param set @p 0
-
 SELECT "d"."Id", "d"."Bar"
 FROM "Data" AS "d"
-WHERE "d"."Bar" = @p
+WHERE NOT ("d"."Bar")
 ---------------

src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorBooleanTests.Create_BooleanNotEqual_Expression.snap

@@ -13,11 +13,9 @@ true Result:
 
 true SQL:
 ---------------
-.param set @__p_0 1
-
 SELECT "d"."Id", "d"."Bar"
 FROM "Data" AS "d"
-WHERE "d"."Bar" <> @__p_0
+WHERE NOT ("d"."Bar")
 ---------------
 
 false Result:
@@ -35,9 +33,7 @@ false Result:
 
 false SQL:
 ---------------
-.param set @__p_0 0
-
 SELECT "d"."Id", "d"."Bar"
 FROM "Data" AS "d"
-WHERE "d"."Bar" <> @__p_0
+WHERE "d"."Bar"
 ---------------

src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorBooleanTests.Create_BooleanNotEqual_Expression_NET10_0.snap

@@ -13,11 +13,9 @@ true Result:
 
 true SQL:
 ---------------
-.param set @p 1
-
 SELECT "d"."Id", "d"."Bar"
 FROM "Data" AS "d"
-WHERE "d"."Bar" <> @p
+WHERE NOT ("d"."Bar")
 ---------------
 
 false Result:
@@ -35,9 +33,7 @@ false Result:
 
 false SQL:
 ---------------
-.param set @p 0
-
 SELECT "d"."Id", "d"."Bar"
 FROM "Data" AS "d"
-WHERE "d"."Bar" <> @p
+WHERE "d"."Bar"
 ---------------

src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectBooleanEqual_Expression.snap

@@ -30,12 +30,10 @@ true Result:
 
 true SQL:
 ---------------
-.param set @__p_0 1
-
 SELECT "d"."Id", "d"."FooId"
 FROM "Data" AS "d"
 INNER JOIN "Foo" AS "f" ON "d"."FooId" = "f"."Id"
-WHERE "f"."BarBool" = @__p_0
+WHERE "f"."BarBool"
 ---------------
 
 false Result:
@@ -55,10 +53,8 @@ false Result:
 
 false SQL:
 ---------------
-.param set @__p_0 0
-
 SELECT "d"."Id", "d"."FooId"
 FROM "Data" AS "d"
 INNER JOIN "Foo" AS "f" ON "d"."FooId" = "f"."Id"
-WHERE "f"."BarBool" = @__p_0
+WHERE NOT ("f"."BarBool")
 ---------------

src/HotChocolate/Data/test/Data.Filters.SqlServer.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectBooleanEqual_Expression_NET10_0.snap

@@ -30,12 +30,10 @@ true Result:
 
 true SQL:
 ---------------
-.param set @p 1
-
 SELECT "d"."Id", "d"."FooId"
 FROM "Data" AS "d"
 INNER JOIN "Foo" AS "f" ON "d"."FooId" = "f"."Id"
-WHERE "f"."BarBool" = @p
+WHERE "f"."BarBool"
 ---------------
 
 false Result:
@@ -55,10 +53,8 @@ false Result:
 
 false SQL:
 ---------------
-.param set @p 0
-
 SELECT "d"."Id", "d"."FooId"
 FROM "Data" AS "d"
 INNER JOIN "Foo" AS "f" ON "d"."FooId" = "f"."Id"
-WHERE "f"."BarBool" = @p
+WHERE NOT ("f"."BarBool")
 ---------------

src/HotChocolate/Data/test/Data.Filters.Tests/Expression/ExecutorBuilder.cs

@@ -13,6 +13,11 @@ public ExecutorBuilder(IFilterInputType inputType)
     }
 
     public Func<T, bool> Build<T>(IValueNode filter)
+    {
+        return BuildExpression<T>(filter).Compile();
+    }
+
+    public Expression<Func<T, bool>> BuildExpression<T>(IValueNode filter)
     {
         var visitorContext = new QueryableFilterContext(_inputType, true);
         var visitor = new FilterVisitor<QueryableFilterContext, Expression>(
@@ -22,7 +27,7 @@ public Func<T, bool> Build<T>(IValueNode filter)
 
         if (visitorContext.TryCreateLambda(out Expression<Func<T, bool>>? where))
         {
-            return where.Compile();
+            return where;
         }
 
         throw new InvalidOperationException();

src/HotChocolate/Data/test/Data.Filters.Tests/Expression/QueryableFilterVisitorBooleanTests.cs

@@ -1,3 +1,4 @@
+using System.Linq.Expressions;
 using HotChocolate.Language;
 
 namespace HotChocolate.Data.Filters.Expressions;
@@ -40,6 +41,93 @@ public void Create_BooleanNotEqual_Expression()
         Assert.False(func(b));
     }
 
+    [Fact]
+    public void Create_BooleanEqual_Expression_True_Uses_Direct_Property()
+    {
+        // arrange
+        var value = Utf8GraphQLParser.Syntax.ParseValueLiteral("{ bar: { eq: true }}");
+        var tester = CreateProviderTester(new FooFilterInput());
+
+        // act
+        var expr = tester.BuildExpression<Foo>(value);
+
+        // assert - the in-memory context wraps with NotNullAndAlso(x, condition),
+        // so the body is AndAlso(x != null, condition). The right side should be
+        // a direct property access (MemberExpression), not an Equal comparison.
+        var andAlso = Assert.IsAssignableFrom<BinaryExpression>(expr.Body);
+        Assert.Equal(ExpressionType.AndAlso, andAlso.NodeType);
+        Assert.IsAssignableFrom<MemberExpression>(andAlso.Right);
+    }
+
+    [Fact]
+    public void Create_BooleanEqual_Expression_False_Uses_Not()
+    {
+        // arrange
+        var value = Utf8GraphQLParser.Syntax.ParseValueLiteral("{ bar: { eq: false }}");
+        var tester = CreateProviderTester(new FooFilterInput());
+
+        // act
+        var expr = tester.BuildExpression<Foo>(value);
+
+        // assert - right side of AndAlso should be Not(property)
+        var andAlso = Assert.IsAssignableFrom<BinaryExpression>(expr.Body);
+        Assert.Equal(ExpressionType.AndAlso, andAlso.NodeType);
+        var not = Assert.IsType<UnaryExpression>(andAlso.Right);
+        Assert.Equal(ExpressionType.Not, not.NodeType);
+        Assert.IsAssignableFrom<MemberExpression>(not.Operand);
+    }
+
+    [Fact]
+    public void Create_BooleanNotEqual_Expression_True_Uses_Not()
+    {
+        // arrange
+        var value = Utf8GraphQLParser.Syntax.ParseValueLiteral("{ bar: { neq: true }}");
+        var tester = CreateProviderTester(new FooFilterInput());
+
+        // act
+        var expr = tester.BuildExpression<Foo>(value);
+
+        // assert - right side of AndAlso should be Not(property)
+        var andAlso = Assert.IsAssignableFrom<BinaryExpression>(expr.Body);
+        Assert.Equal(ExpressionType.AndAlso, andAlso.NodeType);
+        var not = Assert.IsType<UnaryExpression>(andAlso.Right);
+        Assert.Equal(ExpressionType.Not, not.NodeType);
+        Assert.IsAssignableFrom<MemberExpression>(not.Operand);
+    }
+
+    [Fact]
+    public void Create_BooleanNotEqual_Expression_False_Uses_Direct_Property()
+    {
+        // arrange
+        var value = Utf8GraphQLParser.Syntax.ParseValueLiteral("{ bar: { neq: false }}");
+        var tester = CreateProviderTester(new FooFilterInput());
+
+        // act
+        var expr = tester.BuildExpression<Foo>(value);
+
+        // assert - right side of AndAlso should be direct property access
+        var andAlso = Assert.IsAssignableFrom<BinaryExpression>(expr.Body);
+        Assert.Equal(ExpressionType.AndAlso, andAlso.NodeType);
+        Assert.IsAssignableFrom<MemberExpression>(andAlso.Right);
+    }
+
+    [Fact]
+    public void Create_NullableBooleanEqual_Expression_Uses_Equality()
+    {
+        // arrange
+        var value = Utf8GraphQLParser.Syntax.ParseValueLiteral("{ bar: { eq: true }}");
+        var tester = CreateProviderTester(new FooNullableFilterInput());
+
+        // act
+        var expr = tester.BuildExpression<FooNullable>(value);
+
+        // assert - nullable bool should still use Equal (not optimized).
+        // The body is AndAlso(x != null, condition) where condition is Equal.
+        var andAlso = Assert.IsAssignableFrom<BinaryExpression>(expr.Body);
+        Assert.Equal(ExpressionType.AndAlso, andAlso.NodeType);
+        Assert.Equal(ExpressionType.Equal, andAlso.Right.NodeType);
+    }
+
     [Fact]
     public void Create_NullableBooleanEqual_Expression()
     {

src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorBooleanTests.Create_BooleanEqual_Expression.snap

@@ -13,7 +13,7 @@ true Result:
 
 true SQL:
 ---------------
-select d.id, d.data from public.mt_doc_queryablefiltervisitorbooleantests_foo as d where CAST(d.data ->> 'Bar' as boolean) = :p0;
+select d.id, d.data from public.mt_doc_queryablefiltervisitorbooleantests_foo as d where (d.data ->> 'Bar' is not null and CAST(d.data ->> 'Bar' as boolean) = True);
 ---------------
 
 false Result:
@@ -31,5 +31,5 @@ false Result:
 
 false SQL:
 ---------------
-select d.id, d.data from public.mt_doc_queryablefiltervisitorbooleantests_foo as d where CAST(d.data ->> 'Bar' as boolean) = :p0;
+select d.id, d.data from public.mt_doc_queryablefiltervisitorbooleantests_foo as d where (d.data ->> 'Bar' is null or CAST(d.data ->> 'Bar' as boolean) = False);
 ---------------

src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorBooleanTests.Create_BooleanNotEqual_Expression.snap

@@ -13,7 +13,7 @@ true Result:
 
 true SQL:
 ---------------
-select d.id, d.data from public.mt_doc_queryablefiltervisitorbooleantests_foo as d where CAST(d.data ->> 'Bar' as boolean) != :p0;
+select d.id, d.data from public.mt_doc_queryablefiltervisitorbooleantests_foo as d where (d.data ->> 'Bar' is null or CAST(d.data ->> 'Bar' as boolean) = False);
 ---------------
 
 false Result:
@@ -31,5 +31,5 @@ false Result:
 
 false SQL:
 ---------------
-select d.id, d.data from public.mt_doc_queryablefiltervisitorbooleantests_foo as d where CAST(d.data ->> 'Bar' as boolean) != :p0;
+select d.id, d.data from public.mt_doc_queryablefiltervisitorbooleantests_foo as d where (d.data ->> 'Bar' is not null and CAST(d.data ->> 'Bar' as boolean) = True);
 ---------------

src/HotChocolate/Marten/test/Data.Marten.Filters.Tests/__snapshots__/QueryableFilterVisitorObjectTests.Create_ObjectBooleanEqual_Expression.snap

@@ -20,7 +20,7 @@ true Result:
 
 true SQL:
 ---------------
-select d.id, d.data from public.mt_doc_queryablefiltervisitorobjecttests_bar as d where CAST(d.data -> 'Foo' ->> 'BarBool' as boolean) = :p0;
+select d.id, d.data from public.mt_doc_queryablefiltervisitorobjecttests_bar as d where (d.data -> 'Foo' ->> 'BarBool' is not null and CAST(d.data -> 'Foo' ->> 'BarBool' as boolean) = True);
 ---------------
 
 false Result:
@@ -40,5 +40,5 @@ false Result:
 
 false SQL:
 ---------------
-select d.id, d.data from public.mt_doc_queryablefiltervisitorobjecttests_bar as d where CAST(d.data -> 'Foo' ->> 'BarBool' as boolean) = :p0;
+select d.id, d.data from public.mt_doc_queryablefiltervisitorobjecttests_bar as d where (d.data -> 'Foo' ->> 'BarBool' is null or CAST(d.data -> 'Foo' ->> 'BarBool' as boolean) = False);
 ---------------

src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorBooleanTests.Create_BooleanNotEqual_Expression.snap

@@ -13,7 +13,7 @@ true Result:
 
 true SQL:
 ---------------
-from 'Foos' where Bar != $p0
+from 'Foos' where Bar = $p0
 ---------------
 
 false Result:
@@ -31,5 +31,5 @@ false Result:
 
 false SQL:
 ---------------
-from 'Foos' where Bar != $p0
+from 'Foos' where Bar = $p0
 ---------------

src/HotChocolate/Raven/test/Data.Raven.Filters.Tests/__snapshots__/QueryableFilterVisitorExecutableTests.Create_BooleanNotEqual_Expression.snap

@@ -13,7 +13,7 @@ true Result:
 
 true SQL:
 ---------------
-from 'Foos' where Bar != $p0
+from 'Foos' where Bar = $p0
 ---------------
 
 false Result:
@@ -31,5 +31,5 @@ false Result:
 
 false SQL:
 ---------------
-from 'Foos' where Bar != $p0
+from 'Foos' where Bar = $p0
 ---------------