Skip to content

Optimize boolean filter SQL generation for non-nullable bool fields#9151

Merged
michaelstaib merged 5 commits intomainfrom
mst/filter-optimization-1
Feb 19, 2026
Merged

Optimize boolean filter SQL generation for non-nullable bool fields#9151
michaelstaib merged 5 commits intomainfrom
mst/filter-optimization-1

Conversation

@michaelstaib
Copy link
Copy Markdown
Member

@michaelstaib michaelstaib commented Feb 19, 2026

Fixes #9124

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

Fusion Gateway Performance Results

Simple Composite Query

Req/s Err%
Constant (50 VUs) 2981.43 0.00%
Ramping (0-500-0 VUs) 3263.26 0.00%
Response Times & Query
Min Med Avg P90 P95 Max
Constant 0.75ms 14.72ms 16.55ms 30.56ms 36.21ms 171.80ms
Ramping 0.79ms 66.85ms 68.34ms 127.55ms 144.29ms 286.01ms
query TestQuery {
  topProducts(first: 5) {
    inStock
    name
    price
    shippingEstimate
    upc
    weight
    reviews {
      id
      body
      author {
        id
        username
        name
      }
    }
  }
}

Deep Recursion Query

Req/s Err%
Constant (50 VUs) 756.43 0.00%
Ramping (0-500-0 VUs) 821.62 0.00%
Response Times & Query
Min Med Avg P90 P95 Max
Constant 8.88ms 61.45ms 64.58ms 79.86ms 88.09ms 361.14ms
Ramping 1.83ms 251.49ms 262.14ms 526.02ms 567.19ms 698.20ms
query TestQuery {
  users {
    id
    username
    name
    reviews {
      id
      body
      product {
        inStock
        name
        price
        shippingEstimate
        upc
        weight
        reviews {
          id
          body
          author {
            id
            username
            name
            reviews {
              id
              body
              product {
                inStock
                name
                price
                shippingEstimate
                upc
                weight
              }
            }
          }
        }
      }
    }
  }
  topProducts(first: 5) {
    inStock
    name
    price
    shippingEstimate
    upc
    weight
    reviews {
      id
      body
      author {
        id
        username
        name
        reviews {
          id
          body
          product {
            inStock
            name
            price
            shippingEstimate
            upc
            weight
          }
        }
      }
    }
  }
}

Variable Batching Throughput

Req/s Err%
Constant (50 VUs) 23489.44 0.00%
Ramping (0-500-0 VUs) 18415.02 0.00%
Response Times & Query
Min Med Avg P90 P95 Max
Constant 0.10ms 1.72ms 2.08ms 3.97ms 4.87ms 43.03ms
Ramping 0.10ms 9.60ms 11.55ms 23.64ms 28.59ms 99.27ms
query TestQuery($upc: ID!, $price: Long!, $weight: Long!) {
  productByUpc(upc: $upc) {
    inStock
    shippingEstimate(weight: $weight, price: $price)
  }
}

Variables (5 sets batched per request)

[
  { "upc": "1", "price": 899, "weight": 100 },
  { "upc": "2", "price": 1299, "weight": 1000 },
  { "upc": "3", "price": 15, "weight": 20 },
  { "upc": "4", "price": 499, "weight": 100 },
  { "upc": "5", "price": 1299, "weight": 1000 }
]

Run 22204444968 • Commit be29640 • Thu, 19 Feb 2026 23:44:29 GMT

@michaelstaib michaelstaib merged commit 8cb0e53 into main Feb 19, 2026
5 checks passed
@michaelstaib michaelstaib deleted the mst/filter-optimization-1 branch February 19, 2026 23:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6a3b7a3) to head (94faa38).
⚠️ Report is 780 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9151       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid CASE statement for a boolean filter with Entity Framework

1 participant