Fixed various analyzer errors

src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/Execution/DynamicEndpointMiddleware.cs

@@ -175,7 +175,7 @@ private static async Task<JsonDocument> BuildVariablesAsync(
             }
 
             var jsonValueParser = new JsonValueParser(buffer: variableBuffer);
-            var bodyValue =  jsonValueParser.Parse(result.Buffer);
+            var bodyValue = jsonValueParser.Parse(result.Buffer);
             variables[bodyVariable] = bodyValue;
             body.AdvanceTo(result.Buffer.End);
         }

src/HotChocolate/Adapters/src/Adapters.OpenApi/OpenApiResultFormatter.cs

@@ -1,5 +1,3 @@
-using System.Text.Encodings.Web;
-using System.Text.Json;
 using HotChocolate.Execution;
 using HotChocolate.Text.Json;
 using Microsoft.AspNetCore.Http;
@@ -8,12 +6,6 @@ namespace HotChocolate.Adapters.OpenApi;
 
 internal sealed class OpenApiResultFormatter : IOpenApiResultFormatter
 {
-    private static readonly JsonWriterOptions s_jsonWriterOptions =
-        new() { Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping };
-
-    private static readonly JsonSerializerOptions s_jsonSerializerOptions =
-        new() { Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping };
-
     public async Task FormatResultAsync(
         OperationResult operationResult,
         HttpContext httpContext,

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/PolicyType.cs

@@ -3,7 +3,6 @@
 using HotChocolate.Features;
 using HotChocolate.Language;
 using HotChocolate.Text.Json;
-using static HotChocolate.Utilities.ThrowHelper;
 
 namespace HotChocolate.ApolloFederation.Types;
 

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ScopeType.cs

@@ -3,7 +3,6 @@
 using HotChocolate.Features;
 using HotChocolate.Language;
 using HotChocolate.Text.Json;
-using static HotChocolate.Utilities.ThrowHelper;
 
 namespace HotChocolate.ApolloFederation.Types;
 

src/HotChocolate/AspNetCore/src/AspNetCore.CommandLine/WebApplicationExtensions.cs

@@ -1,4 +1,3 @@
-using System.CommandLine.Parsing;
 using HotChocolate.AspNetCore.CommandLine;
 
 namespace Microsoft.Extensions.Hosting;

src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Subscriptions/WebSocketConnection.cs

@@ -6,7 +6,6 @@
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
-using static System.Net.WebSockets.WebSocketMessageType;
 using static HotChocolate.Transport.Sockets.SocketDefaults;
 using static HotChocolate.Transport.Sockets.WellKnownProtocols;
 

src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Utilities/MiddlewareHelper.cs

@@ -234,7 +234,7 @@ await executorSession.OnCreateAsync(
             }
 
             return new ExecuteRequestResult(
-                OperationResult.FromError([..ex.Errors]));
+                OperationResult.FromError([.. ex.Errors]));
         }
         catch (Exception ex)
         {
@@ -352,7 +352,7 @@ public ParseRequestResult(GraphQLRequest request)
         public ParseRequestResult(IReadOnlyList<IError> errors, HttpStatusCode statusCode)
         {
             IsValid = false;
-            Error = OperationResult.FromError([..errors]);
+            Error = OperationResult.FromError([.. errors]);
             StatusCode = statusCode;
             Request = null;
         }

src/HotChocolate/AspNetCore/src/Transport.Http/GraphQLHttpResponse.cs

@@ -3,14 +3,14 @@
 using System.Net;
 using System.Net.Http.Headers;
 using System.IO.Pipelines;
+using HotChocolate.Buffers;
 using HotChocolate.Transport;
 using HotChocolate.Fusion.Text.Json;
 #else
 using System.Net;
 using System.Net.Http.Headers;
 using System.Text.Json;
 #endif
-using HotChocolate.Buffers;
 
 #if FUSION
 namespace HotChocolate.Fusion.Transport.Http;

src/HotChocolate/AspNetCore/test/Transport.Http.Tests/GraphQLHttpClientTests.cs

@@ -814,7 +814,8 @@ mutation CreateReviewForEpisode(
                 ["ep"] = "JEDI",
                 ["review"] = new Dictionary<string, object?>
                 {
-                    ["stars"] = 5, ["commentary"] = "This is a great movie!"
+                    ["stars"] = 5,
+                    ["commentary"] = "This is a great movie!"
                 }
             });
 
@@ -876,7 +877,8 @@ mutation CreateReviewForEpisode(
                 ["ep"] = "JEDI",
                 ["review"] = new Dictionary<string, object?>
                 {
-                    ["stars"] = 5, ["commentary"] = "This is a great movie!"
+                    ["stars"] = 5,
+                    ["commentary"] = "This is a great movie!"
                 }
             });
 
@@ -996,7 +998,8 @@ public async Task Post_GraphQL_FileUpload(string? contentType)
 
         var request = new GraphQLHttpRequest(operation, requestUri)
         {
-            Method = GraphQLHttpMethod.Post, EnableFileUploads = true
+            Method = GraphQLHttpMethod.Post,
+            EnableFileUploads = true
         };
 
         // act
@@ -1054,7 +1057,8 @@ public async Task Post_GraphQL_FileUpload_With_ObjectValueNode(string? contentTy
 
         var request = new GraphQLHttpRequest(operation, requestUri)
         {
-            Method = GraphQLHttpMethod.Post, EnableFileUploads = true
+            Method = GraphQLHttpMethod.Post,
+            EnableFileUploads = true
         };
 
         // act
@@ -1093,7 +1097,8 @@ public async Task Post_Subscription_Over_JsonLines()
                     stars
                   }
                 }
-                """)) { Method = GraphQLHttpMethod.Post, Accept = GraphQLHttpRequest.GraphQLOverHttp };
+                """))
+        { Method = GraphQLHttpMethod.Post, Accept = GraphQLHttpRequest.GraphQLOverHttp };
 
         var mutationRequest = new OperationRequest(
             """
@@ -1110,7 +1115,8 @@ mutation CreateReviewForEpisode(
                 ["ep"] = "JEDI",
                 ["review"] = new Dictionary<string, object?>
                 {
-                    ["stars"] = 5, ["commentary"] = "This is a great movie!"
+                    ["stars"] = 5,
+                    ["commentary"] = "This is a great movie!"
                 }
             });
 
@@ -1154,7 +1160,7 @@ public async Task ReadAsResult_Application_GraphQL_Response_Json_Response()
             "application/graphql-response+json");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.OperationRequest("{ number }");
+        var operationRequest = new OperationRequest("{ number }");
         var request = new GraphQLHttpRequest(operationRequest, new Uri("http://localhost:5000/graphql"));
 
         // act
@@ -1182,7 +1188,7 @@ public async Task ReadAsResult_Application_Json_Response()
             "application/json");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.OperationRequest("{ number }");
+        var operationRequest = new OperationRequest("{ number }");
         var request = new GraphQLHttpRequest(operationRequest, new Uri("http://localhost:5000/graphql"));
 
         // act
@@ -1210,7 +1216,7 @@ public async Task ReadAsResultStream_Single_Application_GraphQL_Response_Json_Re
             "application/graphql-response+json");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.OperationRequest("{ number }");
+        var operationRequest = new OperationRequest("{ number }");
         var request = new GraphQLHttpRequest(operationRequest, new Uri("http://localhost:5000/graphql"));
 
         // act
@@ -1247,7 +1253,7 @@ public async Task ReadAsResultStream_Single_Application_Json_Response()
             "application/json");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.OperationRequest("{ number }");
+        var operationRequest = new OperationRequest("{ number }");
         var request = new GraphQLHttpRequest(operationRequest, new Uri("http://localhost:5000/graphql"));
 
         // act
@@ -1286,7 +1292,7 @@ public async Task ReadAsResultStream_Single_Application_Json_Apollo_Request_Batc
             "application/json");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.OperationBatchRequest(
+        var operationRequest = new OperationBatchRequest(
         [
             new OperationRequest("{ number }")
         ]);
@@ -1333,7 +1339,7 @@ public async Task ReadAsResultStream_Multi_Application_Json_Apollo_Request_Batch
             "application/json");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.OperationBatchRequest(
+        var operationRequest = new OperationBatchRequest(
         [
             new OperationRequest("{ number }"),
             new OperationRequest("{ number }")
@@ -1375,7 +1381,7 @@ public async Task ReadAsResultStream_Single_Application_Json_Lines_Response()
             "application/jsonl");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.VariableBatchRequest(
+        var operationRequest = new VariableBatchRequest(
             "{ number }",
             variables:
             [
@@ -1420,7 +1426,7 @@ public async Task ReadAsResultStream_Multi_Application_Json_Lines_Response()
             "application/jsonl");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.VariableBatchRequest(
+        var operationRequest = new VariableBatchRequest(
             "{ number }",
             variables:
             [
@@ -1470,7 +1476,7 @@ public async Task ReadAsResultStream_Single_Text_Event_Stream_Response()
             "text/event-stream");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.OperationRequest("{ number }");
+        var operationRequest = new OperationRequest("{ number }");
         var request = new GraphQLHttpRequest(operationRequest, new Uri("http://localhost:5000/graphql"));
 
         // act
@@ -1519,7 +1525,7 @@ public async Task ReadAsResultStream_Multi_Text_Event_Stream_Response()
             "text/event-stream");
         using var client = new DefaultGraphQLHttpClient(new HttpClient(handler));
 
-        var operationRequest = new HotChocolate.Transport.OperationRequest("{ number }");
+        var operationRequest = new OperationRequest("{ number }");
         var request = new GraphQLHttpRequest(operationRequest, new Uri("http://localhost:5000/graphql"));
 
         // act
@@ -1552,7 +1558,7 @@ protected override Task<HttpResponseMessage> SendAsync(
             HttpRequestMessage request,
             CancellationToken cancellationToken)
         {
-            var response = new HttpResponseMessage(System.Net.HttpStatusCode.OK)
+            var response = new HttpResponseMessage(HttpStatusCode.OK)
             {
                 Content = new StreamContent(responseStream)
             };

src/HotChocolate/Core/src/Execution.Pipeline/ExceptionMiddleware.cs

@@ -38,7 +38,7 @@ public async ValueTask InvokeAsync(RequestContext context)
         catch (GraphQLException ex)
         {
             var errors = _errorHandler.Handle(ex.Errors);
-            context.Result = OperationResult.FromError([..errors]);
+            context.Result = OperationResult.FromError([.. errors]);
             _diagnosticEvents.RequestError(context, ex);
         }
         catch (Exception ex)

src/HotChocolate/Core/src/Types.Scalars/EmailAddressType.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/HexColorType.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/HslaType.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/IPv4Type.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/IPv6Type.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/IsbnType.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/MacAddressType.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/PhoneNumberType.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/RgbType.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/RgbaType.cs

@@ -1,5 +1,4 @@
 using System.Text.RegularExpressions;
-using HotChocolate.Language;
 
 namespace HotChocolate.Types;
 

src/HotChocolate/Core/src/Types.Scalars/UtcOffsetType.cs

@@ -142,7 +142,7 @@ public static bool TrySerialize(
             [NotNullWhen(true)] out string? result)
             => s_timeSpanToOffset.TryGetValue(value, out result);
 
-        public static bool TryDeserialize( string value, out TimeSpan result)
+        public static bool TryDeserialize(string value, out TimeSpan result)
             => s_offsetToTimeSpan.TryGetValue(value, out result);
     }
 }

src/HotChocolate/Core/src/Types/Execution/Configuration/DefaultRequestExecutorBuilder.cs

@@ -1,5 +1,3 @@
-using Microsoft.Extensions.DependencyInjection;
-
 namespace HotChocolate.Execution.Configuration;
 
 internal class DefaultRequestExecutorBuilder : IRequestExecutorBuilder

src/HotChocolate/Core/src/Types/Execution/Configuration/OnConfigureSchemaServices.cs

@@ -1,5 +1,3 @@
-using Microsoft.Extensions.DependencyInjection;
-
 namespace HotChocolate.Execution.Configuration;
 
 public delegate void OnConfigureSchemaServices(

src/HotChocolate/Core/src/Types/Execution/DependencyInjection/InternalSchemaServiceCollectionExtensions.cs

@@ -1,4 +1,3 @@
-using HotChocolate;
 using HotChocolate.Execution;
 using HotChocolate.Execution.Instrumentation;
 using HotChocolate.Execution.Processing;

src/HotChocolate/Core/src/Types/Execution/DependencyInjection/RequestExecutorBuilderExtensions.ErrorFilter.cs

@@ -52,7 +52,7 @@ public static IRequestExecutorBuilder AddErrorFilter(
     /// The <see cref="IServiceProvider"/> passed to the <paramref name="factory"/>
     /// is for the schema services. If you need to access application services
     /// you need to either make the services available in the schema services
-    /// via <see cref="RequestExecutorBuilderExtensions.AddApplicationService"/> or use
+    /// via <see cref="AddApplicationService"/> or use
     /// <see cref="ExecutionServiceProviderExtensions.GetRootServiceProvider(IServiceProvider)"/>
     /// to access the application services from within the schema service provider.
     /// </remarks>
@@ -83,7 +83,7 @@ public static IRequestExecutorBuilder AddErrorFilter<T>(
     /// <remarks>
     /// The <typeparamref name="T"/> will be activated with the <see cref="IServiceProvider"/> of the schema services.
     /// If your <typeparamref name="T"/> needs to access application services you need to
-    /// make the services available in the schema services via <see cref="RequestExecutorBuilderExtensions.AddApplicationService"/>.
+    /// make the services available in the schema services via <see cref="AddApplicationService"/>.
     /// </remarks>
     public static IRequestExecutorBuilder AddErrorFilter<T>(
         this IRequestExecutorBuilder builder)

src/HotChocolate/Core/src/Types/Execution/DependencyInjection/RequestExecutorBuilderExtensions.Optimizer.cs

@@ -21,7 +21,7 @@ public static partial class RequestExecutorBuilderExtensions
     /// <remarks>
     /// The <typeparamref name="T"/> will be activated with the <see cref="IServiceProvider"/> of the schema services.
     /// If your <typeparamref name="T"/> needs to access application services you need to
-    /// make the services available in the schema services via <see cref="RequestExecutorBuilderExtensions.AddApplicationService"/>.
+    /// make the services available in the schema services via <see cref="AddApplicationService"/>.
     /// </remarks>
     public static IRequestExecutorBuilder AddOperationCompilerOptimizer<T>(
         this IRequestExecutorBuilder builder)
@@ -52,7 +52,7 @@ public static IRequestExecutorBuilder AddOperationCompilerOptimizer<T>(
     /// The <see cref="IServiceProvider"/> passed to the <paramref name="factory"/>
     /// is for the schema services. If you need to access application services
     /// you need to either make the services available in the schema services
-    /// via <see cref="RequestExecutorBuilderExtensions.AddApplicationService"/> or use
+    /// via <see cref="AddApplicationService"/> or use
     /// <see cref="ExecutionServiceProviderExtensions.GetRootServiceProvider(IServiceProvider)"/>
     /// to access the application services from within the schema service provider.
     /// </remarks>

src/HotChocolate/Core/src/Types/Execution/DependencyInjection/RequestExecutorBuilderExtensions.TransactionScope.cs

@@ -25,7 +25,7 @@ public static partial class RequestExecutorBuilderExtensions
     /// <remarks>
     /// The <typeparamref name="T"/> will be activated with the <see cref="IServiceProvider"/> of the schema services.
     /// If your <typeparamref name="T"/> needs to access application services you need to
-    /// make the services available in the schema services via <see cref="RequestExecutorBuilderExtensions.AddApplicationService"/>.
+    /// make the services available in the schema services via <see cref="AddApplicationService"/>.
     /// </remarks>
     public static IRequestExecutorBuilder AddTransactionScopeHandler<T>(
         this IRequestExecutorBuilder builder)
@@ -62,7 +62,7 @@ public static IRequestExecutorBuilder AddTransactionScopeHandler<T>(
     /// The <see cref="IServiceProvider"/> passed to the <paramref name="factory"/>
     /// is for the schema services. If you need to access application services
     /// you need to either make the services available in the schema services
-    /// via <see cref="RequestExecutorBuilderExtensions.AddApplicationService"/> or use
+    /// via <see cref="AddApplicationService"/> or use
     /// <see cref="ExecutionServiceProviderExtensions.GetRootServiceProvider(IServiceProvider)"/>
     /// to access the application services from within the schema service provider.
     /// </remarks>