Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves various C# analyzer warnings across multiple projects (HotChocolate, Fusion-vnext, Nitro CLI, StrawberryShake) by applying small syntax/formatting cleanups and removing unused usings, without changing intended runtime behavior.
Changes:
- Removed/adjusted unused
usingdirectives and fully-qualified type names where no longer necessary. - Fixed minor syntax issues flagged by analyzers (extra semicolons, spacing/formatting, minor refactorings like
out _). - Applied a few targeted API-surface/no-op tweaks to satisfy analyzers (e.g.,
readonly ref struct, pragma suppression around introspection constant names).
Reviewed changes
Copilot reviewed 72 out of 91 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/StrawberryShake/Client/test/Transport.InMemory.Tests/InMemoryClientTests.cs | Remove stray extra semicolon flagged by analyzer. |
| src/Nitro/CommandLine/src/CommandLine/Helpers/GlobMatcher.cs | Formatting/bracing cleanup. |
| src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/Options/OpenApiCollectionFilePatternOption.cs | Spacing around : for analyzer/style compliance. |
| src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/ListOpenApiCollectionCommand.cs | Indentation/spacing cleanup. |
| src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/DeleteOpenApiCollectionCommand.cs | Indentation/spacing cleanup. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/Options/McpToolFilePatternOption.cs | Spacing around : for analyzer/style compliance. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/Options/McpPromptFilePatternOption.cs | Spacing around : for analyzer/style compliance. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/ListMcpFeatureCollectionCommand.cs | Indentation/spacing cleanup. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/DeleteMcpFeatureCollectionCommand.cs | Indentation/spacing cleanup. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionValidateCommand.cs | Remove unused using + object initializer formatting. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishCommand.cs | Remove stray extra semicolon flagged by analyzer. |
| src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionComposeCommand.cs | Tuple deconstruction spacing cleanup. |
| src/HotChocolate/Utilities/src/Utilities.Buffers/JsonMemory.cs | Whitespace cleanup in null-check. |
| src/HotChocolate/Utilities/src/Utilities.Buffers/FixedSizeArrayPool.cs | Whitespace cleanup in null-check. |
| src/HotChocolate/Spatial/test/Types.Tests/GeoJsonTypeSerializerTests.cs | Replace unused out var with out _. |
| src/HotChocolate/Spatial/src/Data/Projections/Extensions/Extensions/QueryableSpatialProjectionScalarHandler.cs | Modifier ordering cleanup (static new). |
| src/HotChocolate/Primitives/src/Primitives/Types/IntrospectionTypeNames.cs | Add pragma suppression for IDE naming rule on __* constants. |
| src/HotChocolate/MongoDb/test/Data.MongoDb.Projections.Tests/ProjectionVisitorTestBase.cs | Whitespace cleanup. |
| src/HotChocolate/MongoDb/src/Types/BsonType.cs | Remove unused using. |
| src/HotChocolate/Language/test/Language.Tests/Parser/QueryParserTests.cs | Remove stray extra semicolons in tests. |
| src/HotChocolate/Language/src/Language.Web/Utf8GraphQLSocketMessageParser.cs | Mark parser as readonly ref struct to satisfy analyzer/immutability expectations. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Execution.Tests/Transport/Http/DefaultGraphQLHttpClientTests.cs | Use HotChocolate.Transport imports (avoid fully qualified type names). |
| src/HotChocolate/Fusion-vnext/test/Fusion.Execution.Tests/Execution/FusionRequestExecutorManagerTests.cs | Remove unused using. |
| src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/LookupTests.cs | Minor style fixes (var, loop variable, Encoding, indentation). |
| src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/FusionTestBase.cs | Object initializer formatting cleanup. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Utilities/Rewriters/InlineFragmentOperationRewriter.cs | Whitespace cleanup in if conditions. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Text/Json/SourceResultDocument.cs | Remove unused using. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Text/Json/CompositeResultDocument.cs | Remove unused using. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/OperationPlanContext.cs | Remove unused using. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Clients/SourceSchemaHttpClient.cs | Remove unused using. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/ThrowHelper.cs | Remove unused using(s)/blank line. |
| src/HotChocolate/Fusion-vnext/benchmarks/Fusion.Execution.Benchmarks/GraphQLQueryBenchmark.cs | Remove unused using. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Listeners/ActivityExecutionDiagnosticListener.cs | Remove unused using. |
| src/HotChocolate/Data/test/Data.PostgreSQL.Tests/Types/Brands/BrandNode.cs | Remove unused using. |
| src/HotChocolate/Data/src/Data/Projections/Context/SelectedField.cs | Remove unused using. |
| src/HotChocolate/Data/src/Data/Filters/Extensions/HotChocolateDataQueryableExtensions.cs | Remove unused using. |
| src/HotChocolate/Core/test/Types.Tests/Types/Scalars/AnyTypeTests.cs | Fix extra whitespace in assertion. |
| src/HotChocolate/Core/test/Execution.Tests/Processing/VisibilityTests.cs | Remove unused using. |
| src/HotChocolate/Core/test/Execution.Tests/Integration/DataLoader/Query.cs | Remove unused using. |
| src/HotChocolate/Core/src/Validation/Rules/OverlappingFieldsCanBeMergedRule.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Types/Scalars/ScalarType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Types/Scalars/FloatTypeBase.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Resolvers/SelectionEnumerator.cs | Whitespace cleanup. |
| src/HotChocolate/Core/src/Types/Fetching/Extensions/DataLoaderServiceProviderExtensions.cs | Remove unused using(s)/blank line. |
| src/HotChocolate/Core/src/Types/Fetching/Extensions/DataLoaderResolverContextExtensions.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Fetching/ExecutionDataLoaderScopeFactory.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Fetching/DataLoaderScopeHolder.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Fetching/DataLoaderRootFieldTypeInterceptor.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/RequestExecutorManager.cs | Simplify AddSingleton call while preserving registration behavior. |
| src/HotChocolate/Core/src/Types/Execution/RequestExecutorManager.Warmup.cs | Remove unused using(s)/blank line. |
| src/HotChocolate/Core/src/Types/Execution/RequestExecutorManager.Hooks.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Processing/SubscriptionExecutor.cs | Collection-expression spacing cleanup. |
| src/HotChocolate/Core/src/Types/Execution/Processing/OperationOptimizerContext.cs | Remove unused using(s)/blank line. |
| src/HotChocolate/Core/src/Types/Execution/Processing/OperationFeatureCollection.cs | Simplify generic call site (type inference). |
| src/HotChocolate/Core/src/Types/Execution/Processing/OperationCompilerOptimizers.cs | Remove unused using(s). |
| src/HotChocolate/Core/src/Types/Execution/Processing/DefaultActivator.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Processing/ArgumentMap.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Pipeline/TimeoutMiddleware.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Pipeline/RequestClassMiddlewareFactory.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Pipeline/OperationVariableCoercionMiddleware.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Instrumentation/IExecutionDiagnosticEvents.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Instrumentation/ExecutionDiagnosticEventListener.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Instrumentation/AggregateExecutionDiagnosticEvents.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Extensions/OperationContextExtensions.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/DependencyInjection/RequestExecutorBuilderExtensions.TransactionScope.cs | Doc comment link simplification to satisfy analyzers. |
| src/HotChocolate/Core/src/Types/Execution/DependencyInjection/RequestExecutorBuilderExtensions.Optimizer.cs | Doc comment link simplification to satisfy analyzers. |
| src/HotChocolate/Core/src/Types/Execution/DependencyInjection/RequestExecutorBuilderExtensions.ErrorFilter.cs | Doc comment link simplification to satisfy analyzers. |
| src/HotChocolate/Core/src/Types/Execution/DependencyInjection/InternalSchemaServiceCollectionExtensions.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types/Execution/Configuration/OnConfigureSchemaServices.cs | Remove unused using(s)/blank line. |
| src/HotChocolate/Core/src/Types/Execution/Configuration/DefaultRequestExecutorBuilder.cs | Remove unused using(s)/blank line. |
| src/HotChocolate/Core/src/Types.Scalars/UtcOffsetType.cs | Fix spacing in method signature. |
| src/HotChocolate/Core/src/Types.Scalars/RgbaType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/RgbType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/PhoneNumberType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/MacAddressType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/IsbnType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/IPv6Type.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/IPv4Type.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/HslaType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/HexColorType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Types.Scalars/EmailAddressType.cs | Remove unused using. |
| src/HotChocolate/Core/src/Execution.Pipeline/ExceptionMiddleware.cs | Collection-expression spacing cleanup. |
| src/HotChocolate/AspNetCore/test/Transport.Http.Tests/GraphQLHttpClientTests.cs | Use imported transport request types + formatting cleanups in tests. |
| src/HotChocolate/AspNetCore/src/Transport.Http/GraphQLHttpResponse.cs | Fix conditional using placement for analyzers/formatting. |
| src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Utilities/MiddlewareHelper.cs | Collection-expression spacing cleanup. |
| src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Subscriptions/WebSocketConnection.cs | Remove unused static using. |
| src/HotChocolate/AspNetCore/src/AspNetCore.CommandLine/WebApplicationExtensions.cs | Remove unused using. |
| src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ScopeType.cs | Remove unused static using. |
| src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/PolicyType.cs | Remove unused static using. |
| src/HotChocolate/Adapters/src/Adapters.OpenApi/OpenApiResultFormatter.cs | Remove unused JSON options fields/usings (no longer referenced). |
| src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/Execution/DynamicEndpointMiddleware.cs | Fix double-space typo in assignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
🚀 Fusion Gateway Performance ResultsSimple Composite QueryConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query fragment User on User {
id
username
name
}
fragment Review on Review {
id
body
}
fragment Product on Product {
inStock
name
price
shippingEstimate
upc
weight
}
query TestQuery {
topProducts(first: 5) {
...Product
reviews {
...Review
author {
...User
}
}
}
}Deep Recursion QueryConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query fragment User on User {
id
username
name
}
fragment Review on Review {
id
body
}
fragment Product on Product {
inStock
name
price
shippingEstimate
upc
weight
}
query TestQuery {
users {
...User
reviews {
...Review
product {
...Product
reviews {
...Review
author {
...User
reviews {
...Review
product {
...Product
}
}
}
}
}
}
}
topProducts(first: 5) {
...Product
reviews {
...Review
author {
...User
reviews {
...Review
product {
...Product
}
}
}
}
}
}Variable Batching ThroughputConstant Load (50 VUs)
📊 Response Time Metrics
Ramping Load (0→50→500→50 VUs)
📊 Response Time Metrics
Executed Query query TestQuery_8f7a46ce_2(
$__fusion_1_upc: ID!
$__fusion_2_price: Long!
$__fusion_2_weight: Long!
) {
productByUpc(upc: $__fusion_1_upc) {
inStock
shippingEstimate(weight: $__fusion_2_weight, price: $__fusion_2_price)
}
}Variables (5 sets batched in single request) [
{ "__fusion_1_upc": "1", "__fusion_2_price": 899, "__fusion_2_weight": 100 },
{ "__fusion_1_upc": "2", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 },
{ "__fusion_1_upc": "3", "__fusion_2_price": 15, "__fusion_2_weight": 20 },
{ "__fusion_1_upc": "4", "__fusion_2_price": 499, "__fusion_2_weight": 100 },
{ "__fusion_1_upc": "5", "__fusion_2_price": 1299, "__fusion_2_weight": 1000 }
]No baseline data available for comparison. Run 21825362304 • Commit 5fa75f7 • Mon, 09 Feb 2026 12:55:04 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)