Repository navigation
Add Fusion Transport Layer - #8410
Merged
Merged
Conversation
michaelstaib
commented
Jul 1, 2025
michaelstaib
commented
Jul 1, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds foundational transport abstractions and integrates them into existing HTTP and WebSocket transports, while replacing legacy buffer helpers with a unified pooled writer approach across the codebase. Key changes include:
- Refactored low-level buffering: removed
BufferHelper, updatedPooledArrayWriterto implementIMemoryOwner<byte>withWrittenMemory/WrittenSpan, and introducedPooledArrayWriterMarshalandJsonDocumentOwner. - Switched all direct calls from
GetWrittenMemory/GetWrittenSpanto the new properties, and updated JSON parsing/formatting accordingly. - Consolidated context data keys by replacing many usages of
WellKnownContextDatawithExecutionContextData.
Reviewed Changes
Copilot reviewed 175 out of 234 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/HotChocolate/Utilities/src/Utilities/BufferHelper.cs | Removed; streaming logic now uses PooledArrayWriter directly. |
| src/HotChocolate/Utilities/src/Utilities.Buffers/PooledArrayWriter.cs | Changed to implement IMemoryOwner<byte>, added WrittenMemory/WrittenSpan, and removed legacy methods. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/FusionRequestExecutorManager.cs | Added channel-based observer pattern for executor creation/eviction and a file-scoped extensions helper. |
| src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/Extensions/ServiceCollectionExtensions.cs | Introduced a custom AddHttpClient extension to wire TestServer into IHttpClientFactory for tests. |
Files not reviewed (1)
- src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Properties/AspNetCorePipelineResources.Designer.cs: Language not supported
Comments suppressed due to low confidence (2)
src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Pipeline/OperationVariableCoercionMiddleware.cs:44
- Changing
TryCoerceVariablesfrom public to private restricts its accessibility and may break callers who rely on it; consider preserving its public API surface or updating all references.
private static bool TryCoerceVariables(
src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/FusionRequestExecutorManager.cs:589
- [nitpick] The class name
Extensionsis very generic and could clash with other extension-method classes; consider renaming it to something more descriptive.
file static class Extensions
Comment on lines
+49
to
+59
| const int chunkSize = 256; | ||
| await using var stream = new FileStream(filePath, FileMode.Open, FileAccess.Read); | ||
| using var writer = new PooledArrayWriter(); | ||
| var read = 0; | ||
|
|
||
| var document = await BufferHelper.ReadAsync( | ||
| stream, | ||
| static (buffer, buffered) => | ||
| { | ||
| var span = buffer.AsSpan()[..buffered]; | ||
| return Utf8GraphQLParser.Parse(span); | ||
| }, | ||
| cancellationToken) | ||
| .ConfigureAwait(false); | ||
| do | ||
| { | ||
| var memory = writer.GetMemory(chunkSize); | ||
| read = await stream.ReadAsync(memory, cancellationToken).ConfigureAwait(false); | ||
| writer.Advance(read); | ||
| } while (read == chunkSize); |
There was a problem hiding this comment.
[nitpick] Using a fixed chunk size of 256 bytes may cause many small reads for larger files; consider increasing or making this buffer size configurable to reduce IO overhead.
JesseXia
pushed a commit
to JesseXia/graphql-platform
that referenced
this pull request
Aug 7, 2025
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.