Repository navigation
Remove the dead HttpContext.Items read from ParseContentType - #10453
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Removes the unused HttpContext.Items lookup from ParseContentType, reducing request allocations while preserving content-type handling.
Changes:
- Parses
ContentTypedirectly. - Preserves JSON, multipart, and query handling.
| File | Summary |
|---|---|
src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Extensions/HttpContextExtensions.cs |
Removes the obsolete Items lookup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseContentTypeopened by looking upHttpContext.Items["RequestContentType"], a key nothing has written since Add Fusion Transport Layer #8410 moved the method intoHttpContextExtensions. The lookup never hit, and on a request where nothing else had touchedItemsit created the Items feature: 48 bytes on every POST, QUERY, and multipart request on Kestrel.MapGraphQL, which was never documented.Test plan
HotChocolate.AspNetCore.TestsandHotChocolate.Fusion.AspNetCore.Testspass onnet10.0. The Fusion gateway runs the same request middlewares.