Skip to content

fix: return 400 for gossip validation errors #9699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 2 commits into from
Jul 24, 2026
Merged

fix: return 400 for gossip validation errors #9699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d3c392
fix: return 400 for gossip validation errors
nflaig Jul 23, 2026
ad6d276
test: remove REST error handler tests
nflaig Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/beacon-node/src/api/rest/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {parse as parseQueryString} from "qs";
import {addSszContentTypeParser} from "@lodestar/api/server";
import {NUMBER_OF_COLUMNS} from "@lodestar/params";
import {ErrorAborted, Gauge, Histogram, Logger} from "@lodestar/utils";
import {GossipActionError} from "../../chain/errors/gossipValidation.js";
import {isLocalhostIP} from "../../util/ip.js";
import {ApiError, FailureList, IndexedError, NodeIsSyncing} from "../impl/errors.js";
import {HttpActiveSocketsTracker, SocketMetrics} from "./activeSockets.js";
Expand Down Expand Up @@ -121,8 +122,8 @@ export class RestApiServer {
};
void res.status(err.statusCode).send(payload);
} else {
// Convert our custom ApiError into status code
const statusCode = err instanceof ApiError ? err.statusCode : 500;
// Convert known request errors into status codes
const statusCode = err instanceof ApiError ? err.statusCode : err instanceof GossipActionError ? 400 : 500;
const payload: ErrorResponse = {code: statusCode, message: err.message, stacktraces};
void res.status(statusCode).send(payload);
}
Expand Down Expand Up @@ -170,7 +171,11 @@ export class RestApiServer {

const operationId = getOperationId(req);

if (err instanceof ApiError || [INVALID_MEDIA_TYPE_CODE, SCHEMA_VALIDATION_ERROR_CODE].includes(err.code)) {
if (
err instanceof ApiError ||
err instanceof GossipActionError ||
[INVALID_MEDIA_TYPE_CODE, SCHEMA_VALIDATION_ERROR_CODE].includes(err.code)
) {
this.logger.warn(`Req ${req.id} ${operationId} failed`, {reason: err.message});
} else {
this.logger.error(`Req ${req.id} ${operationId} error`, {}, err);
Expand Down
Loading