fix: return 400 for gossip validation errors - #9699
Merged
Merged
Conversation
nflaig
marked this pull request as ready for review
July 23, 2026 18:19
Contributor
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jul 23, 2026
Member
|
馃帀 This PR is included in v1.46.0 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map
GossipActionErrorto 400 at the REST boundary. BothIGNOREandREJECTmean the submitted object did not pass gossip validation; unexpected errors continue to return 500.This fixes
publishExecutionPayloadBidreturning 500 when proposer preferences are missing and covers other Beacon API publish endpoints using the same gossip validation errors.see https://github.com/ethereum/beacon-APIs/blob/master/apis/beacon/execution_payload/bid.yaml
Checks:
pnpm lintpnpm check-types