Skip to content

fix: remove Gloas deposit request limit - #9617

Merged
nflaig merged 3 commits into
glamsterdam-devnet-7from
nc/remove-gloas-deposit-request-limit-devnet7
Jul 7, 2026
Merged

fix: remove Gloas deposit request limit#9617
nflaig merged 3 commits into
glamsterdam-devnet-7from
nc/remove-gloas-deposit-request-limit-devnet7

Conversation

@nflaig

@nflaig nflaig commented Jul 7, 2026

Copy link
Copy Markdown
Member

@nflaig
nflaig requested a review from a team as a code owner July 7, 2026 10:24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the serialization and deserialization of deposit requests to support both Electra and Gloas forks depending on the active fork. A unit test has been added to verify Gloas deposit requests beyond the Electra limit. Feedback is provided to explicitly cast the deposit requests in the ternary operator to ensure strict type safety.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/beacon-node/src/execution/engine/types.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挕 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38b476bf97

鈩癸笍 About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 馃憤.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/beacon-node/src/execution/engine/types.ts
@nflaig
nflaig merged commit b383a48 into glamsterdam-devnet-7 Jul 7, 2026
13 of 16 checks passed
@nflaig
nflaig deleted the nc/remove-gloas-deposit-request-limit-devnet7 branch July 7, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants