Skip to content

refactor: align bid filtering with consensus spec #9182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nflaig merged 3 commits into from
Apr 6, 2026
Merged

refactor: align bid filtering with consensus spec #9182

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d478722
docs: align bid filtering key comment with spec
nflaig Apr 5, 2026
d9519d3
Apply suggestion from @nflaig
nflaig Apr 5, 2026
71c3460
reorder args
nflaig Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/beacon-node/src/chain/validation/executionPayloadBid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ async function validateExecutionPayloadBid(
});
}

// [IGNORE] this bid is the highest value bid seen for the corresponding slot
// and the given parent block hash.
// [IGNORE] this bid is the highest value bid seen for the tuple
// (bid.slot, bid.parent_block_hash, bid.parent_block_root).
Comment thread
nflaig marked this conversation as resolved.
Resolved
Comment thread
nflaig marked this conversation as resolved.
Resolved
const bestBid = chain.executionPayloadBidPool.getBestBid(parentBlockRootHex, parentBlockHashHex, bid.slot);
if (bestBid !== null && bestBid.value >= bid.value) {
throw new ExecutionPayloadBidError(GossipAction.IGNORE, {
Expand Down
Loading