refactor: align bid filtering with consensus spec - #9182
Merged
Conversation
Update to match consensus-specs#5001 wording. The underlying implementation already keys bids by the (slot, parent_block_root, parent_block_hash) tuple.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation comment in executionPayloadBid.ts to clarify that bids are evaluated based on a tuple of slot, parent block hash, and parent block root. A review comment identifies an inconsistency in the field ordering within the comment compared to the actual implementation and provides a suggestion to align them.
nflaig
commented
Apr 5, 2026
nflaig
changed the title
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
nflaig
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9182 +/- ##
=========================================
Coverage 52.53% 52.53%
=========================================
Files 848 848
Lines 61429 61429
Branches 4528 4528
=========================================
Hits 32270 32270
Misses 29094 29094
Partials 65 65 🚀 New features to boost your workflow:
|
Member
|
🎉 This PR is included in v1.43.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to match ethereum/consensus-specs#5001 wording. The underlying implementation already keys bids by the (slot, parent_block_root, parent_block_hash) tuple.