fix: override MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS for Gnosis#9075
Conversation
Gnosis config was inheriting mainnet's value of 4096 for MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS. With Gnosis's faster block times (5s slots, 16 slots/epoch), this gives only ~3.7 days of data column retention instead of the intended ~15 days. The official Gnosis config specifies 16384: https://github.com/gnosischain/configs/blob/main/mainnet/config.yaml This matches the existing MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS override already present in the Gnosis config. Without this fix, once Fulu activates on Gnosis: - Lodestar nodes prune data columns after ~3.7 days - Other clients retain them for ~15 days - Lodestar would refuse to serve older data columns via DataColumnSidecarsByRoot requests
|
To use Codex here, create a Codex account and connect to github. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical configuration mismatch for the Gnosis chain, specifically addressing the data column sidecar retention period. The change ensures that the application adheres to the official Gnosis network specifications, thereby preventing issues like premature data pruning, refusal of serving older data, and maintaining interoperability with other clients on the network. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly overrides the MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS for the Gnosis chain configuration. The new value of 16384 aligns with the official Gnosis specification, fixing an issue where the incorrect value was inherited from the mainnet configuration. This change ensures the data column retention window is appropriate for Gnosis's block time. The change is well-documented and correct.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9075 +/- ##
=========================================
Coverage 52.28% 52.28%
=========================================
Files 848 848
Lines 62155 62155
Branches 4544 4544
=========================================
Hits 32498 32498
Misses 29592 29592
Partials 65 65 🚀 New features to boost your workflow:
|
…#9075) ## Problem The Gnosis chain config inherits mainnet's `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 4096`, but the [official Gnosis config](https://github.com/gnosischain/configs/blob/main/mainnet/config.yaml) specifies `16384`. With Gnosis's faster block times (5s slots, 16 slots/epoch), this drastically shortens the data column retention window: | Config | Epochs | Retention | |--------|--------|-----------| | Mainnet (4096 × 32 slots × 12s) | 4096 | **~18.2 days** | | Gnosis with wrong 4096 (4096 × 16 slots × 5s) | 4096 | **~3.7 days** ❌ | | Gnosis with correct 16384 (16384 × 16 slots × 5s) | 16384 | **~15.2 days** ✅ | ### Impact (once Fulu activates on Gnosis) 1. **Premature pruning**: Lodestar prunes data columns after ~3.7 days instead of ~15 days 2. **Refuses serving**: `DataColumnSidecarsByRoot` handler rejects requests for columns older than ~3.7 days (`packages/beacon-node/src/network/reqresp/handlers/dataColumnSidecarsByRoot.ts:22-27`) 3. **Archive pruning**: Block archiver prunes data column sidecars too aggressively (`packages/beacon-node/src/chain/archiveStore/utils/archiveBlocks.ts:171-195`) 4. **Interop mismatch**: Other clients using the correct 16384 would retain data for ~15 days, causing Lodestar to diverge from the network ### Evidence - Official Gnosis config: [`MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 16384`](https://github.com/gnosischain/configs/blob/main/mainnet/config.yaml) - The existing `MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS: 16384` override is already present in `gnosis.ts` (line 35) — this is the same pattern ## Fix Add `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 16384` to the Gnosis chain config, matching the official Gnosis config and the existing blob sidecars override. Flagged by @chatgpt-codex-connector in #9074 (comment) Co-authored-by: lodekeeper <lodekeeper@users.noreply.github.com>
|
🎉 This PR is included in v1.41.1 🎉 |
3 participants
Problem
The Gnosis chain config inherits mainnet's
MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 4096, but the official Gnosis config specifies16384.With Gnosis's faster block times (5s slots, 16 slots/epoch), this drastically shortens the data column retention window:
Impact (once Fulu activates on Gnosis)
DataColumnSidecarsByRoothandler rejects requests for columns older than ~3.7 days (packages/beacon-node/src/network/reqresp/handlers/dataColumnSidecarsByRoot.ts:22-27)packages/beacon-node/src/chain/archiveStore/utils/archiveBlocks.ts:171-195)Evidence
MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 16384MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS: 16384override is already present ingnosis.ts(line 35) — this is the same patternFix
Add
MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 16384to the Gnosis chain config, matching the official Gnosis config and the existing blob sidecars override.Flagged by @chatgpt-codex-connector in #9074 (comment)