feat: schedule Fulu fork for Gnosis mainnet#9074
Conversation
Epoch: 1714688, Slot: 27435008 UTC: Tue Apr 14 2026 12:06:20
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request configures the Fulu hard fork for the Gnosis mainnet by updating its activation epoch and timestamp. This change is crucial for preparing the network for the upcoming protocol upgrade, ensuring all nodes are aligned for the scheduled fork. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request schedules the Fulu fork for the Gnosis mainnet by setting the FULU_FORK_EPOCH. The change is functionally correct. I have added one comment to improve code consistency by aligning the date format in the code comment with the existing format in the file.
nflaig
changed the title
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7f52355af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Fulu | ||
| FULU_FORK_VERSION: b("0x06000064"), | ||
| FULU_FORK_EPOCH: Infinity, | ||
| FULU_FORK_EPOCH: 1714688, // Tue Apr 14 2026 12:06:20 GMT+0000 |
There was a problem hiding this comment.
Once FULU_FORK_EPOCH becomes finite here, Gnosis starts using MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS in the Fulu request/pruning paths (packages/beacon-node/src/network/reqresp/handlers/dataColumnSidecarsByRoot.ts:22-27 and packages/beacon-node/src/chain/archiveStore/utils/archiveBlocks.ts:187-195). This network file still inherits mainnet’s 4096 from packages/config/src/chainConfig/configs/mainnet.ts:181, but the Gnosis config schedules 16384; on Gnosis’s 16-slot epochs that cuts the required retention window from about 15 days to about 3.8 days, so post-fork nodes will prune/refuse older data columns much earlier than other clients.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9074 +/- ##
=========================================
Coverage 52.28% 52.28%
=========================================
Files 848 848
Lines 62165 62165
Branches 4544 4544
=========================================
Hits 32503 32503
Misses 29597 29597
Partials 65 65 🚀 New features to boost your workflow:
|
…#9075) ## Problem The Gnosis chain config inherits mainnet's `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 4096`, but the [official Gnosis config](https://github.com/gnosischain/configs/blob/main/mainnet/config.yaml) specifies `16384`. With Gnosis's faster block times (5s slots, 16 slots/epoch), this drastically shortens the data column retention window: | Config | Epochs | Retention | |--------|--------|-----------| | Mainnet (4096 × 32 slots × 12s) | 4096 | **~18.2 days** | | Gnosis with wrong 4096 (4096 × 16 slots × 5s) | 4096 | **~3.7 days** ❌ | | Gnosis with correct 16384 (16384 × 16 slots × 5s) | 16384 | **~15.2 days** ✅ | ### Impact (once Fulu activates on Gnosis) 1. **Premature pruning**: Lodestar prunes data columns after ~3.7 days instead of ~15 days 2. **Refuses serving**: `DataColumnSidecarsByRoot` handler rejects requests for columns older than ~3.7 days (`packages/beacon-node/src/network/reqresp/handlers/dataColumnSidecarsByRoot.ts:22-27`) 3. **Archive pruning**: Block archiver prunes data column sidecars too aggressively (`packages/beacon-node/src/chain/archiveStore/utils/archiveBlocks.ts:171-195`) 4. **Interop mismatch**: Other clients using the correct 16384 would retain data for ~15 days, causing Lodestar to diverge from the network ### Evidence - Official Gnosis config: [`MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 16384`](https://github.com/gnosischain/configs/blob/main/mainnet/config.yaml) - The existing `MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS: 16384` override is already present in `gnosis.ts` (line 35) — this is the same pattern ## Fix Add `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 16384` to the Gnosis chain config, matching the official Gnosis config and the existing blob sidecars override. Flagged by @chatgpt-codex-connector in #9074 (comment) Co-authored-by: lodekeeper <lodekeeper@users.noreply.github.com>
Schedule Fulu fork for Gnosis mainnet. - Epoch: 1714688 - Timestamp: 1776168380 - UTC: Tue Apr 14 2026 12:06:20 Matches: gnosischain/configs#50, gnosischain/specs#92 --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…#9075) ## Problem The Gnosis chain config inherits mainnet's `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 4096`, but the [official Gnosis config](https://github.com/gnosischain/configs/blob/main/mainnet/config.yaml) specifies `16384`. With Gnosis's faster block times (5s slots, 16 slots/epoch), this drastically shortens the data column retention window: | Config | Epochs | Retention | |--------|--------|-----------| | Mainnet (4096 × 32 slots × 12s) | 4096 | **~18.2 days** | | Gnosis with wrong 4096 (4096 × 16 slots × 5s) | 4096 | **~3.7 days** ❌ | | Gnosis with correct 16384 (16384 × 16 slots × 5s) | 16384 | **~15.2 days** ✅ | ### Impact (once Fulu activates on Gnosis) 1. **Premature pruning**: Lodestar prunes data columns after ~3.7 days instead of ~15 days 2. **Refuses serving**: `DataColumnSidecarsByRoot` handler rejects requests for columns older than ~3.7 days (`packages/beacon-node/src/network/reqresp/handlers/dataColumnSidecarsByRoot.ts:22-27`) 3. **Archive pruning**: Block archiver prunes data column sidecars too aggressively (`packages/beacon-node/src/chain/archiveStore/utils/archiveBlocks.ts:171-195`) 4. **Interop mismatch**: Other clients using the correct 16384 would retain data for ~15 days, causing Lodestar to diverge from the network ### Evidence - Official Gnosis config: [`MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 16384`](https://github.com/gnosischain/configs/blob/main/mainnet/config.yaml) - The existing `MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS: 16384` override is already present in `gnosis.ts` (line 35) — this is the same pattern ## Fix Add `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS: 16384` to the Gnosis chain config, matching the official Gnosis config and the existing blob sidecars override. Flagged by @chatgpt-codex-connector in #9074 (comment) Co-authored-by: lodekeeper <lodekeeper@users.noreply.github.com>
|
🎉 This PR is included in v1.41.1 🎉 |
4 participants
Schedule Fulu fork for Gnosis mainnet.
Matches: gnosischain/configs#50, gnosischain/specs#92