feat: fulu types #7774
Merged
feat: fulu types #7774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
commented
Apr 30, 2025
nflaig
reviewed
Apr 30, 2025
wemeetagain
commented
Apr 30, 2025
wemeetagain
commented
Apr 30, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7774 +/- ##
============================================
+ Coverage 56.05% 56.08% +0.03%
============================================
Files 837 823 -14
Lines 57906 57961 +55
Branches 4450 4452 +2
============================================
+ Hits 32459 32508 +49
- Misses 25379 25385 +6
Partials 68 68 🚀 New features to boost your workflow:
|
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
May 1, 2025
| [ForkName.fulu]: {...phase0Ssz, ...altairSsz, ...bellatrixSsz, ...capellaSsz, ...denebSsz, ...electraSsz, ...fuluSsz}, | ||
| }; | ||
|
|
||
| // Export these types to ensure that each fork is a superset of the previous one (with overridden types obviously) |
nflaig
reviewed
May 1, 2025
matthewkeil
requested changes
May 1, 2025
Member
matthewkeil
left a comment
matthewkeil
left a comment
There was a problem hiding this comment.
A couple small nits but otherwise LGTM!!
| [ForkName.fulu]: {...phase0Ssz, ...altairSsz, ...bellatrixSsz, ...capellaSsz, ...denebSsz, ...electraSsz, ...fuluSsz}, | ||
| }; | ||
|
|
||
| // Export these types to ensure that each fork is a superset of the previous one (with overridden types obviously) |
matthewkeil
reviewed
May 1, 2025
Co-authored-by: Nico Flaig <[email protected]> Co-authored-by: Matthew Keil <[email protected]>
matthewkeil
requested changes
May 2, 2025
packages/params/src/forkName.ts
Outdated
Comment on lines
113
to
120
| export type ForkPreBlobs = ForkPreDeneb; | ||
| export type ForkPostBlobs = ForkPostFulu; | ||
| export type ForkBlobs = ForkName.deneb | ForkName.electra; | ||
| export const forkBlobs = [ForkName.deneb, ForkName.electra]; | ||
| export function isForkBlobs(fork: ForkName): fork is ForkBlobs { | ||
| return fork === ForkName.deneb || fork === ForkName.electra; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This is something I feel very strongly about. They should be added back
Member
There was a problem hiding this comment.
if you can properly articulate why this is needed I am fine with it but so far the arguments weren't even technically correct, especially adding those in this PR doesn't make any sense + they are technically also a breaking change, we had isForkBlobs already for 2 years, now we are rebranding it to something else
blobs vs. columns makes sense if you only look at sync + gossip but it doesn't if you look more holistically at the system as a whole, the EL still uses blobs, we even have an api that returns blobs, engine api returns blobs etc. etc. so claiming we remove blobs in Fulu also is not correct
the main argument was that we have to use 1 more function call
isForkPostDeneb && isForkPreFulu which stinks
why is this such a big deal? this is very explicit, or could even do fork >= ForkSeq.deneb && fork < ForkSeq.fulu maybe even better
when I first looked at the PR I didn't even get what isForkBlobs and was confused why we added it here, then I saw it just covered deneb and electra
there just so much wrong with this, I guess we have a stalemate here 😁
This was referenced May 3, 2025
matthewkeil
approved these changes
May 4, 2025
Member
matthewkeil
left a comment
matthewkeil
left a comment
There was a problem hiding this comment.
LGTM!! Can add back forkBlobs if we find it important later
wemeetagain
added a commit
that referenced
this pull request
May 12, 2025
**Motivation** - continuation of #7734 and #7745 - dependent on #7774 **Description** - Add new `BlockInput` classes to eventually replace our block input functions - These classes track data availability per block root, with preDA, blobs, and columns DA implemented --------- Co-authored-by: matthewkeil <[email protected]>
Member
Author
|
🎉 This PR is included in v1.30.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
peerDASbranch