feat: handle chain stall in peer manager #7508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
previously approved these changes
Mar 11, 2025
Member
nflaig
left a comment
nflaig
left a comment
There was a problem hiding this comment.
LGTM - we have tested this for a while on holesky-rescue branch and it was very useful to speed up our sync times + retrieving more details about our connected peers, see discord thread for more details
twoeths
reviewed
Mar 12, 2025
twoeths
reviewed
Mar 12, 2025
| return StatusScore.FAR_AHEAD; | ||
| } | ||
|
|
||
| // It seems dangerous to downscore peers that are far behind. |
Contributor
There was a problem hiding this comment.
if we ever return FAR_BEHIND, then lodestar nodes will most likely disconnect peers that want to sync from us which is not great for the network. Should we remove FAR_BEHIND completely? or add more info for it
if we delete FAR_BEHIND enum then there is only 2 options: CLOSE_TO_US and FAR_AHEAD. At synced time, this function will always return CLOSE_TO_US. Hence the main usage for this function is for syncing time
please add all of these to the function description for later reference
twoeths
reviewed
Mar 12, 2025
twoeths
reviewed
Mar 12, 2025
Contributor
twoeths
left a comment
twoeths
left a comment
There was a problem hiding this comment.
the feature is great, I dropped some comments/suggestions
nflaig
reviewed
Mar 13, 2025
| buckets: [0.001, 0.01, 0.1, 1], | ||
| }), | ||
| starved: register.gauge({ | ||
| name: "lodestar_peer_manager_starved_bool", |
Member
There was a problem hiding this comment.
if you have time would be good to add a panel somewhere that uses the bool
twoeths
previously approved these changes
Mar 14, 2025
nflaig
previously approved these changes
Mar 14, 2025
Member
|
seems like we need to update tests here I leave this up to you @wemeetagain to make sure it's done correctly, I don't think we need this in 1.28, so there is no rush |
nflaig
reviewed
May 3, 2025
| ...formatNodePeer(peerIdStr, connections), | ||
| agentVersion: peerData?.agentVersion ?? "NA", | ||
| status: peerData?.status ? ssz.phase0.Status.toJson(peerData.status) : null, | ||
| metadata: peerData?.metadata ? ssz.altair.Metadata.toJson(peerData.metadata) : null, |
Member
There was a problem hiding this comment.
once Fusaka goes live we should update this to use fulu.Metadata, or just if-else based on clock slot but we need the type first #7774
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7508 +/- ##
============================================
- Coverage 56.04% 56.03% -0.02%
============================================
Files 823 823
Lines 57892 57951 +59
Branches 4453 4461 +8
============================================
+ Hits 32448 32472 +24
- Misses 25376 25411 +35
Partials 68 68 🚀 New features to boost your workflow:
|
Member
Author
|
🎉 This PR is included in v1.30.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
starvedcheck in the peer manager heartbeatstarvedwhen its head hasn't updates since the last heartbeat and is behindSTARVATION_THRESHOLD_SLOTSstarvedand has at leasttargetPeers, attempt to prune an additionaltargetPeers * STARVATION_PRUNE_RATIOpeersstarved, disallow pruning of peers that areFAR_AHEADof usstarvedor not, adjust the sorting for pruning to disfavor pruning peers that areFAR_AHEADof us