Skip to content

fix: increment seq_number on metadata cgc changes #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewkeil merged 1 commit into from
Apr 29, 2025
Merged

fix: increment seq_number on metadata cgc changes #7752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/beacon-node/src/network/metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export class MetadataController {
return;
}
this.onSetValue(ENRKey.cgc, serializeCgc(custodyGroupCount));
this._metadata.seqNumber++;
this._metadata.custodyGroupCount = custodyGroupCount;
}

Expand Down
19 changes: 19 additions & 0 deletions packages/beacon-node/test/unit/network/metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,24 @@ describe("network / metadata", () => {
metadata.custodyGroupCount = 128;
expect(onSetValue).toHaveBeenCalledWith(ENRKey.cgc, serializeCgc(128));
});

it("should increment seqNumber when cgc is updated", () => {
const onSetValue = vi.fn();
const networkConfig = new NetworkConfig(getValidPeerId(), config);
const metadata = new MetadataController({}, {onSetValue, networkConfig});
const initialSeqNumber = metadata.seqNumber;
metadata.custodyGroupCount = 128;
expect(metadata.seqNumber).toBe(initialSeqNumber + 1n);
});

it("should not increment seqNumber when cgc is set to the same value", () => {
const onSetValue = vi.fn();
const networkConfig = new NetworkConfig(getValidPeerId(), config);
const metadata = new MetadataController({}, {onSetValue, networkConfig});
metadata.custodyGroupCount = 128;
const initialSeqNumber = metadata.seqNumber;
metadata.custodyGroupCount = 128;
expect(metadata.seqNumber).toBe(initialSeqNumber);
});
});
});