fix: increment seq_number on metadata cgc changes#7752
Merged
matthewkeil merged 1 commit intoChainSafe:peerDASfrom Apr 29, 2025
Merged
fix: increment seq_number on metadata cgc changes#7752matthewkeil merged 1 commit intoChainSafe:peerDASfrom
matthewkeil merged 1 commit intoChainSafe:peerDASfrom
Conversation
twoeths
approved these changes
Apr 26, 2025
nflaig
approved these changes
Apr 26, 2025
hughy
force-pushed
the
peerDAS-metadata-cgc-increment-seq-number
branch
from
0a7fbed to
aaf0e19
Compare
Contributor
Author
|
I rebased this on top of #7751 to avoid conflicts from the rename from |
Member
merged the PR, I think you have to rebase this one once more |
increment seq_number when the metadata cgc field changes to follow phase0 spec definition of seq_number
hughy
force-pushed
the
peerDAS-metadata-cgc-increment-seq-number
branch
from
aaf0e19 to
7565d08
Compare
Member
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
phase0 spec states that
seq_numbershould be incremented by 1 whenever any other field in metadata changes: https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/p2p-interface.md#metadataDescription
increment seq_number when the metadata cgc field changes