Skip to content

feat: implement execution layer exits eip 7002 - #6651

Merged
g11tech merged 4 commits into
electra-forkfrom
elexits-7002
Apr 22, 2024
Merged

feat: implement execution layer exits eip 7002#6651
g11tech merged 4 commits into
electra-forkfrom
elexits-7002

Conversation

@g11tech

@g11tech g11tech commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

@g11tech
g11tech requested a review from a team as a code owner April 8, 2024 14:21
@philknows philknows mentioned this pull request Apr 9, 2024
Closed
12 tasks
@codecov

codecov Bot commented Apr 10, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (electra-fork@5808ddb). Click here to learn what that means.
The diff coverage is 43.61%.

Additional details and impacted files 
@@               Coverage Diff               @@
##             electra-fork    #6651   +/-   ##
===============================================
  Coverage                ?   61.94%           
===============================================
  Files                   ?      563           
  Lines                   ?    59935           
  Branches                ?     1905           
===============================================
  Hits                    ?    37128           
  Misses                  ?    22766           
  Partials                ?       41

@g11tech
g11tech force-pushed the electra-fork branch 2 times, most recently from 8a4f66e to 473a04f Compare April 11, 2024 11:12
twoeths
twoeths reviewed Apr 13, 2024
View reviewed changes
Comment thread packages/state-transition/src/block/processExecutionLayerExit.ts Outdated
twoeths
twoeths reviewed Apr 13, 2024
View reviewed changes
Comment thread packages/state-transition/src/block/processExecutionLayerExit.ts Outdated
twoeths
twoeths reviewed Apr 13, 2024
View reviewed changes
Comment thread packages/types/src/electra/sszTypes.ts Outdated
twoeths
twoeths reviewed Apr 13, 2024
View reviewed changes
Comment thread packages/types/src/electra/sszTypes.ts Outdated
twoeths
twoeths reviewed Apr 13, 2024
View reviewed changes
Comment thread packages/state-transition/src/block/processExecutionLayerExit.ts
twoeths
twoeths reviewed Apr 13, 2024
View reviewed changes
Comment thread packages/state-transition/src/block/processExecutionLayerExit.ts Outdated
twoeths
twoeths reviewed Apr 13, 2024
View reviewed changes
Comment thread packages/state-transition/src/block/processExecutionLayerExit.ts Outdated
twoeths
twoeths reviewed Apr 13, 2024
View reviewed changes
Comment thread packages/beacon-node/test/unit/chain/rewards/blockRewards.test.ts Outdated
ensi321
ensi321 reviewed Apr 13, 2024
View reviewed changes

@ensi321 ensi321 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6646 should already fixed some of the CI issues in blockRewards.test.ts and electra-interop.test.ts. Please pull the latest changes from electra-fork branch

wemeetagain
wemeetagain reviewed Apr 15, 2024
View reviewed changes

@wemeetagain wemeetagain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with @tuyennhv 's comments, otherwise LGTM 🚀

@g11tech

g11tech commented Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

merging with electra fork for now any other changes could be addressed later

@g11tech
g11tech merged commit 4828e06 into electra-fork Apr 22, 2024
@g11tech
g11tech deleted the elexits-7002 branch April 22, 2024 13:48
g11tech added a commit that referenced this pull request May 4, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
30bdac7 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request May 24, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
851b7c9 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit to g11tech/lodestar that referenced this pull request Jun 19, 2024
@g11tech
feat: implement execution layer exits eip 7002 (ChainSafe#6651)
ade5c5d 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Jun 25, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
133ae7f 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Jun 25, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
3a8a4be 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Jul 1, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
2bca717 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Jul 30, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
e7ea5ba 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Jul 31, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
e29e2c6 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Aug 2, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
bcd3c52 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Aug 9, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
54862dd 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Aug 9, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
d2d4959 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Aug 23, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
d670c16 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request Aug 27, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
4b707a9 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
philknows pushed a commit that referenced this pull request Sep 3, 2024
@g11tech @philknows
feat: implement execution layer exits eip 7002 (#6651)
d181a5c 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
@wemeetagain

wemeetagain commented Sep 17, 2024

Copy link
Copy Markdown
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wemeetagain wemeetagain wemeetagain left review comments
@twoeths twoeths twoeths left review comments
@ensi321 ensi321 ensi321 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@g11tech @wemeetagain @twoeths @ensi321