chore: fix CI failure due to recent merge from unstable

[ensi321]

Fix CI errors on electra-fork branch

Motivation

Currently electra-fork branch has some CIs not passing due to the recent merge from unstable. This includes

1. Lint fail - electra-interop.test.ts imports lodash package, which was removed in unstable. See the job log for detail
2. Check types fail - blockRewards.test.ts has relies on generatePerfTestCachedStateAltair() to generate CachedBeaconStateAltair (I know this is bad and we need to fix this soon). CachedBeaconStateAltair is later casted as CachedBeaconStateAllForks. This is due to a private property named historicalValidatorLengths being added to EpochCache. See the job log
3. Spec test fail - We are using v1.4.0-beta.6 for spec test which contains experimental fork eip6110. In electra-fork we remove eip6110 fork and 6110 related code to fork electra. Spec test failed because it is looking for fork eip6110 See the job log
4. e2e test fail - Attempt to download presets from electra fork, which doesn't exist until later spec version

Description

1. Cease lodash dependency in electra-interop.test.ts
2. Remove private modifier for Epoch.historicalValidatorLengths
3. Ignore eip6110 spec test

Long Term Solution

1. Stops blockRewards.test.ts from using generatePerfTestCachedStateAltair() when there is a better utility class to generate a well-formed state
2. Bump spec test version - Recent spec test release removes eip6110 fork and adds electra fork

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (electra-fork@473a04f). Click here to learn what that means.
The diff coverage is 100.00%.

Additional details and impacted files

@@               Coverage Diff               @@
##             electra-fork    #6646   +/-   ##
===============================================
  Coverage                ?   61.97%           
===============================================
  Files                   ?      562           
  Lines                   ?    59844           
  Branches                ?     1905           
===============================================
  Hits                    ?    37089           
  Misses                  ?    22714           
  Partials                ?       41           

[twoeths]

@ensi321 could you clarify which errors and link to the failed CI

[nflaig]

But jokes aside, what happened on electra branch that states between forks can't even be type casted anymore? Doing as unknown as someOtherType is almost the same as just doing as any which means we have disabled typescript at this point. It might be required in some rare cases but should always add a comment to clarify why this is needed

On unstable branch this is not an issue

lodestar/packages/beacon-node/test/unit/chain/rewards/blockRewards.test.ts

Line 140 in 7fadd30

const postState = stateTransition(preState as CachedBeaconStateAllForks, block, {

so not sure if this is the right fix here

[nflaig]

I looked a this locally and don't see the issue, probably not a blocker to merge this but needs to be investigated sooner or later

[nflaig]

In electra-fork, CachedBeaonStateElectra is introduced to CachedBeaconStateAllForks which adds more difference, this is why check-types complains about "insufficiently overlaps". See the job log

Not sure if this explains it, Deneb, or even Bellatrix state have sufficient difference, adding more properties shouldn't break the type cast. I would assume it breaks if you modify or remove a property

[twoeths]

agree, should add a comment to look into that later. Otherwise I'm afraid the same pattern will be applied everywhere

[ensi321]

In electra-fork, CachedBeaonStateElectra is introduced to CachedBeaconStateAllForks which adds more difference, this is why check-types complains about "insufficiently overlaps". See the job log

Not sure if this explains it, Deneb, or even Bellatrix state have sufficient difference, adding more properties shouldn't break the type cast. I would assume it breaks if you modify or remove a property

I just spent some time looking into this. It looks like it's because in electra-fork branch there is a newly added field in EpochCache named private historialValidatorLengths.

So when casting from CachedBeaconStateAltair to CachedBeaconStateAllForks, instead of comparing the two structurally, it's now comparing nominally because of the private property.

I just removed the private modifier of historialValidatorLengths in favour of cleaner code.

Sorry for the incorrect explanation I previous made

[nflaig]

So when casting from CachedBeaconStateAltair to CachedBeaconStateAllForks, instead of comparing the two structurally, it's now comparing nominally because of the private property.

Thanks for investigating that, this is much better than having to cast as unknown. Why marking the property as private causes issues is a bit strange though, it should only check the pubic interface.

Might be related to a typescript bug microsoft/TypeScript#37621, @matthewkeil this is similar to what you observed on the shuffling refactor branch?

[ensi321]

@ensi321 could you clarify which errors and link to the failed CI

@tuyennhv My bad, should've clarified it when opening the PR. Updated the PR description.

[nflaig]

LGTM

[nflaig]

e2e tests are failing due to the fork config not being available on github yet

lodestar/packages/params/test/e2e/ensure-config-is-synced.test.ts

Line 40 in 5ccae1c

url: `https://raw.githubusercontent.com/ethereum/consensus-specs/${commit}/presets/${preset}/${forkName}.yaml`,

See https://github.com/ChainSafe/lodestar/actions/runs/8645222684/job/23702584714?pr=6646#step:6:35

[ensi321]

e2e tests are failing due to the fork config not being available on github yet

lodestar/packages/params/test/e2e/ensure-config-is-synced.test.ts

Line 40 in 5ccae1c

url: `https://raw.githubusercontent.com/ethereum/consensus-specs/${commit}/presets/${preset}/${forkName}.yaml`,

See https://github.com/ChainSafe/lodestar/actions/runs/8645222684/job/23702584714?pr=6646#step:6:35

Yea the error should go away when we upgrade our spec test version

[wemeetagain]

🎉 This PR is included in v1.22.0 🎉