Skip to content

switched to lerna - #324

Merged
wemeetagain merged 4 commits into
masterfrom
greg/lerna
Jul 16, 2019
Merged

switched to lerna#324
wemeetagain merged 4 commits into
masterfrom
greg/lerna

Conversation

@GregTheGreek

Copy link
Copy Markdown
Member

This supersedes #283

Sets up lerna and makes lodestar the only package

@GregTheGreek GregTheGreek added PR state: needs review prio-high Resolve issues as soon as possible. labels Jul 16, 2019
@GregTheGreek
GregTheGreek requested a review from a team July 16, 2019 05:53

@mpetrunic mpetrunic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you accidentally committed packages/lodestar/validator-db

@mpetrunic

Copy link
Copy Markdown
Member

I would move eslint to root to enforce style on all packages.
Reference implementation: https://github.com/typescript-eslint/typescript-eslint
We can do this is subsequent PR

mpetrunic
mpetrunic previously approved these changes Jul 16, 2019
@GregTheGreek
GregTheGreek requested a review from a team July 16, 2019 16:03

@wemeetagain wemeetagain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wemeetagain
wemeetagain merged commit 11bb7bc into master Jul 16, 2019
@wemeetagain
wemeetagain deleted the greg/lerna branch July 16, 2019 21:13
@dapplion dapplion mentioned this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prio-high Resolve issues as soon as possible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants