Skip to content

Setup Lerna - #283

Closed
GregTheGreek wants to merge 41 commits into
masterfrom
greg/feature/lerna
Closed

Setup Lerna#283
GregTheGreek wants to merge 41 commits into
masterfrom
greg/feature/lerna

Conversation

@GregTheGreek

@GregTheGreek GregTheGreek commented Jul 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Adds Lerna to seperate types from the beacon into their own npm module

TODO: Fix failing tests:

Tree Structure

.
├── .babel-register
├── .babelrc
├── .codecov.yml
├── .dockerignore
├── .eslintrc
├── .gitignore
├── .gitmodules
├── .nycrc.json
├── .travis.yml
├── CONTRIBUTING.md
├── LICENSE
├── README.md
├── config_files
│   ├── .babel-register
│   ├── .babelrc
│   ├── .codecov.yml
│   ├── .eslintrc
│   ├── .nycrc.json
│   ├── LICENSE
│   └── tsconfig.json
├── lerna.json
├── package.json
├── packages
│   ├── eth2-types
│   │   ├── .babel-register
│   │   ├── .babelrc
│   │   ├── .codecov.yml
│   │   ├── .eslintrc
│   │   ├── .gitignore
│   │   ├── .nyc_output
│   │   ├── .nycrc.json
│   │   ├── LICENSE
│   │   ├── README.md
│   │   ├── coverage
│   │   ├── lib
│   │   ├── node_modules
│   │   ├── package.json
│   │   ├── src
│   │   ├── test
│   │   └── tsconfig.json
│   └── lodestar
│       ├── .babel-register
│       ├── .babelrc
│       ├── .codecov.yml
│       ├── .eslintrc
│       ├── .gitignore
│       ├── .nyc_output
│       ├── .nycrc.json
│       ├── LICENSE
│       ├── bin
│       ├── coverage
│       ├── docker
│       ├── keys
│       ├── node_modules
│       ├── package.json
│       ├── scripts
│       ├── src
│       ├── test
│       └── tsconfig.json
├── tsconfig.json
└── yarn.lock

@GregTheGreek
GregTheGreek requested a review from a team July 3, 2019 21:59
mpetrunic
mpetrunic reviewed Jul 4, 2019
View reviewed changes
Comment thread lerna-debug.log Outdated
Comment thread packages/beaconChain/package.json
@GregTheGreek GregTheGreek added this to the Sprint 1 milestone Jul 4, 2019
@GregTheGreek GregTheGreek added PR state: WIP prio-medium Resolve this some time soon (tm). labels Jul 4, 2019
mpetrunic
mpetrunic reviewed Jul 4, 2019
View reviewed changes

@mpetrunic mpetrunic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of this comments are probably premature

Comment thread .travis.yml Outdated
Comment thread packages/eth2-types/package.json Outdated
Comment thread packages/eth2-types/package.json Outdated
Comment thread packages/eth2-types/package.json Outdated
Comment thread packages/lodestar/src/chain/factory/attestation/index.ts Outdated
Comment thread packages/lodestar/package.json
Comment thread packages/lodestar/package.json
mpetrunic
mpetrunic suggested changes Jul 6, 2019
View reviewed changes

@mpetrunic mpetrunic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove package-lock.json in lodestar directory

Comment thread lerna.json Outdated
Comment thread packages/eth2-types/package.json Outdated
Comment thread packages/eth2-types/test/consistency.test.ts Outdated
Comment thread packages/eth2-types/test/consistency.test.ts Outdated
Comment thread packages/eth2-types/tsconfig.json Outdated
Comment thread packages/lodestar/package.json Outdated
Comment thread packages/lodestar/src/chain/factory/attestation/data.ts Outdated
mpetrunic
mpetrunic reviewed Jul 6, 2019
View reviewed changes
Comment thread packages/lodestar/package.json Outdated
@GregTheGreek
GregTheGreek marked this pull request as ready for review July 8, 2019 13:10
@GregTheGreek

GregTheGreek commented Jul 8, 2019

Copy link
Copy Markdown
Member Author

I've marked this ready for review because from a structural point of view its ready, I just have a few loose ends to close up:

  1. Travis is adding a random build, labeled nodejs/*lts, to a few of our stages that is causing an outright failure
  2. eth2-types is failing on interface bool does not exist
  3. lodestar test: spec is failing because the submodules don't seem to be pulled in

@mpetrunic

mpetrunic commented Jul 8, 2019

Copy link
Copy Markdown
Member

We should merge all ready pull request adn integrate here before merging though

@GregTheGreek

GregTheGreek commented Jul 8, 2019

Copy link
Copy Markdown
Member Author

We should merge all ready pull request adn integrate here before merging though

Yeah that makes sense, all new PR's will be blocked by this one

@GregTheGreek GregTheGreek added status-do-not-merge Merging this issue will break the build. Do not merge! PR state: on-ice and removed PR state: needs changes status-do-not-merge Merging this issue will break the build. Do not merge! labels Jul 12, 2019
@GregTheGreek GregTheGreek mentioned this pull request Jul 16, 2019
Merged
@GregTheGreek GregTheGreek removed the prio-medium Resolve this some time soon (tm). label Jul 16, 2019
@mpetrunic
mpetrunic deleted the greg/feature/lerna branch July 20, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mpetrunic mpetrunic mpetrunic requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Sprint 1

Development

Successfully merging this pull request may close these issues.

2 participants

@GregTheGreek @mpetrunic